Skip to content

Override isDeployed For 7702 Implementation#46

Merged
hanzel98 merged 8 commits into
mainfrom
chore/override-is-deployed-function2
Aug 6, 2025
Merged

Override isDeployed For 7702 Implementation#46
hanzel98 merged 8 commits into
mainfrom
chore/override-is-deployed-function2

Conversation

@hanzel98

@hanzel98 hanzel98 commented Aug 3, 2025

Copy link
Copy Markdown
Contributor

📝 Description

  • Adds a new action to validate if the 7702 implementation is correctly deployed/implemented in the account provided for it.

🔄 What Changed?

List the specific changes made:

  • New action that validated is an account address is using the correct Gator 7702 implementation.
  • Overrides the isDeployed function for the 7702 implementation

🚀 Why?

Explain the motivation behind these changes:

  • The function isDeployed from viem only validates that there is code in the address to mark it as deployed true, but this doesn't guarantee that it has the correct 7702 implementation.

🧪 How to Test?

Describe how to test these changes:

  • Automated tests added/updated
  • All existing tests pass

⚠️ Breaking Changes

List any breaking changes:

  • No breaking changes

📋 Checklist

Check off completed items:

  • Code follows the project's coding standards
  • Self-review completed
  • Documentation updated (if needed)
  • Tests added/updated
  • Changelog updated (if needed)
  • All CI checks pass

🔗 Related Issues

Link to related issues:
Related to # https://app.zenhub.com/workspaces/readable-permissions-67982ce51eb4360029b2c1a1/issues/gh/metamask/delegator-readable-permissions/241

@hanzel98 hanzel98 requested a review from a team as a code owner August 3, 2025 13:53
@hanzel98 hanzel98 self-assigned this Aug 3, 2025
@hanzel98 hanzel98 marked this pull request as draft August 3, 2025 13:53
@hanzel98 hanzel98 changed the title Chore/override is deployed function2 Override is Deployed With Implementation Aug 4, 2025
@hanzel98 hanzel98 marked this pull request as ready for review August 5, 2025 00:13
jeffsmale90
jeffsmale90 previously approved these changes Aug 5, 2025

@jeffsmale90 jeffsmale90 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A couple minor nits, but LGTM!

Comment thread packages/delegation-toolkit/test/actions/isValid7702Implementation.test.ts Outdated
Comment thread packages/delegation-toolkit/src/actions/isValid7702Implementation.ts Outdated
Comment thread packages/delegation-toolkit/src/actions/isValid7702Implementation.ts Outdated
Comment thread packages/delegation-toolkit/src/actions/isValid7702Implementation.ts Outdated
@cursor

cursor Bot commented Aug 5, 2025

Copy link
Copy Markdown

🚨 Bugbot Trial Expired

Your team's Bugbot trial has expired. Please contact your team administrator to turn on the paid plan to continue using Bugbot.

A team admin can activate the plan in the Cursor dashboard.

@hanzel98 hanzel98 force-pushed the chore/override-is-deployed-function2 branch from 55f41ae to 618aa48 Compare August 5, 2025 02:04
@cursor

cursor Bot commented Aug 5, 2025

Copy link
Copy Markdown

🚨 Bugbot Trial Expired

Your team's Bugbot trial has expired. Please contact your team administrator to turn on the paid plan to continue using Bugbot.

A team admin can activate the plan in the Cursor dashboard.

@cursor

cursor Bot commented Aug 5, 2025

Copy link
Copy Markdown

🚨 Bugbot Trial Expired

Your team's Bugbot trial has expired. Please contact your team administrator to turn on the paid plan to continue using Bugbot.

A team admin can activate the plan in the Cursor dashboard.

@cursor

cursor Bot commented Aug 5, 2025

Copy link
Copy Markdown

🚨 Bugbot Trial Expired

Your team's Bugbot trial has expired. Please contact your team administrator to turn on the paid plan to continue using Bugbot.

A team admin can activate the plan in the Cursor dashboard.

jeffsmale90
jeffsmale90 previously approved these changes Aug 5, 2025

@jeffsmale90 jeffsmale90 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Comment thread packages/delegator-e2e/test/execute-stateless7702.test.ts Outdated
@cursor

cursor Bot commented Aug 5, 2025

Copy link
Copy Markdown

🚨 Bugbot Trial Expired

Your team's Bugbot trial has expired. Please contact your team administrator to turn on the paid plan to continue using Bugbot.

A team admin can activate the plan in the Cursor dashboard.

@hanzel98 hanzel98 requested a review from jeffsmale90 August 5, 2025 16:31
@hanzel98 hanzel98 changed the title Override is Deployed With Implementation Override isDeployed For 7702 Implementation Aug 5, 2025

@jeffsmale90 jeffsmale90 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@hanzel98 hanzel98 merged commit 9a18557 into main Aug 6, 2025
51 of 65 checks passed
@hanzel98 hanzel98 deleted the chore/override-is-deployed-function2 branch August 6, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants