Update erc-7715 client to latest spec#53
Closed
jeffsmale90 wants to merge 1 commit into
Closed
Conversation
…tation Co-authored-by: jeff.smale <jeff.smale@consensys.net>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR updates the experimental ERC-7715 client in the delegation toolkit to align with the latest ERC-7715 specification changes.
🔄 What Changed?
wallet_grantPermissionstowallet_requestExecutionPermissions.grantPermissionstorequestExecutionPermissions.@metamask/permission-types.native-token-stream,native-token-periodic,erc20-token-stream, anderc20-token-periodicpermission types.@metamask/permission-typesas a dependency to@metamask/delegation-toolkit.erc7715GrantPermissionsAction.tstoerc7715RequestExecutionPermissionsAction.tsand updated imports/exports.expiryfield from permission requests, as it is no longer part of the ERC specification.erc7715GrantPermissionsAction.test.tstoerc7715RequestExecutionPermissionsAction.test.ts).🚀 Why?
@metamask/permission-typespackage for consistency across MetaMask projects.🧪 How to Test?
To run the specific tests for these changes:
yarn workspace @metamask/permission-types run buildyarn workspace @metamask/delegation-toolkit vitest test/experimental/erc7715RequestExecutionPermissionsAction.test.tsgrantPermissionsmethod and action have been renamed torequestExecutionPermissions.expiryfield is no longer supported in permission requests.📋 Checklist
Check off completed items:
🔗 Related Issues
Closes #
Related to #
📚 Additional Notes
The full monorepo build/tests might surface unrelated errors due to missing/resolution failures for
@metamask/delegation-abisand@metamask/delegation-corerequired elsewhere in the toolkit. The new ERC-7715 action code compiles, and its dedicated tests are set up to pass.