Fix MultiTokenPeriodBuilder to accept a config object#80
Merged
Conversation
…parameter breaks declarative interface
hanzel98
reviewed
Sep 16, 2025
Comment on lines
+724
to
+733
| .addCaveat('multiTokenPeriod', { | ||
| tokenConfigs: [ | ||
| { | ||
| token: erc20TokenAddress, | ||
| periodAmount, | ||
| periodDuration, | ||
| startDate: futureStartDate, | ||
| }, | ||
| ], | ||
| } as any) |
Contributor
There was a problem hiding this comment.
Is it needed to use as any ?
the same is done below but there is one example above without it
Collaborator
Author
There was a problem hiding this comment.
Definitely shouldn't have these! I've fixed it, thanks!
hanzel98
previously approved these changes
Sep 16, 2025
Contributor
|
I wonder why you needed to add tsx |
hanzel98
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MultiTokenPeriodBuilderaccepts an array as it's config. This is problematic when applied to the declarative API, which expects to be able to squash the config object onto the declarative config.📝 Description
Previously the builder would accept an array
builder.addCaveat("multiTokenPeriod", [ { token, ... } ]).With this change, the builder now accepts an object with
tokenConfigs.builder.addCaveat("multiTokenPeriod", { tokenConfigs: [ { token, ... } ] }).Although it doesn't necessarily make sense to use this caveat to attenuate any of the existing scopes, it's important to have consistency across all caveat types.