Skip to content

Add TransferWindow enum to constants and export it from index#86

Merged
mj-kiwi merged 2 commits into
mainfrom
feat/add-transfer-windows-enum
Oct 15, 2025
Merged

Add TransferWindow enum to constants and export it from index#86
mj-kiwi merged 2 commits into
mainfrom
feat/add-transfer-windows-enum

Conversation

@mj-kiwi

@mj-kiwi mj-kiwi commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

📝 Description

Add a new TransferWindow enum to the constants file and export it from the index to provide a standardized way to reference transfer windows across the project.

🔄 What Changed?

  • Added TransferWindow enum in constants.ts
  • Exported TransferWindow from the index.ts

🚀 Why?

  • Standardize transfer window references to reduce hardcoded strings
  • Improve type safety and maintainability across the codebase

🧪 How to Test?

  • Manual testing steps:

    1. Import TransferWindow in a component or service
    2. Verify that enum values match expected transfer window definitions
    3. Confirm no runtime errors occur when using the enum
  • Automated tests added/updated

  • All existing tests pass

⚠️ Breaking Changes

  • No breaking changes
  • Breaking changes (describe below):

📋 Checklist

  • Code follows the project's coding standards
  • Self-review completed
  • Documentation updated (if needed)
  • Tests added/updated
  • Changelog updated (if needed)
  • All CI checks pass

🔗 Related Issues

Closes #
Related to #

📚 Additional Notes

This enum will be useful for future updates where transfer windows need to be referenced in a type-safe way.


Note

Introduce TransferWindow enum with common second-based intervals and export it from the package index.

  • Constants (packages/delegation-toolkit/src/constants.ts):
    • Add TransferWindow enum with second-based intervals: Hourly, Daily, Weekly, BiWeekly, Monthly, Quarterly, Yearly.
  • Public API (packages/delegation-toolkit/src/index.ts):
    • Export TransferWindow alongside Implementation.

Written by Cursor Bugbot for commit cde49a6. This will update automatically on new commits. Configure here.

@mj-kiwi mj-kiwi requested a review from a team as a code owner October 9, 2025 00:00

@jeffsmale90 jeffsmale90 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @AyushBherwani1998 fyi

@mj-kiwi mj-kiwi merged commit 5cc2b2c into main Oct 15, 2025
17 checks passed
@mj-kiwi mj-kiwi deleted the feat/add-transfer-windows-enum branch October 15, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants