Skip to content

feat: promote readable permissions actions#91

Merged
jeffsmale90 merged 3 commits into
mainfrom
feat/promote-permissions-actions
Nov 7, 2025
Merged

feat: promote readable permissions actions#91
jeffsmale90 merged 3 commits into
mainfrom
feat/promote-permissions-actions

Conversation

@jeffsmale90

@jeffsmale90 jeffsmale90 commented Nov 3, 2025

Copy link
Copy Markdown
Collaborator

📝 Description

This PR promotes the EIP-7715 and EIP-7710 actions from experimental.

🧪 How to Test?

All existing functionality remains unchanged, except the imports are now @metamask/smart-accounts-kit/actions rather than @metamask/smart-accounts-kit/experimental

  • Automated tests added/updated
  • All existing tests pass

⚠️ Breaking Changes

List any breaking changes:

  • No breaking changes
  • Breaking changes (describe below):

Experimental EIP-7710 and EIP-7715 actions must now be imported from @metamask/smart-accounts-kit/actions

📋 Checklist

Check off completed items:

  • Code follows the project's coding standards
  • Self-review completed
  • Documentation updated (if needed)
  • Tests added/updated
  • Changelog updated (if needed)
  • All CI checks pass

🔗 Related Issues

Link to related issues:
Closes #
Related to #

📚 Additional Notes

Any additional information, concerns, or context:


Note

Promotes EIP-7710 and EIP-7715 actions to stable exports under @metamask/smart-accounts-kit/actions, updating imports, tests, and docs.

  • Actions (stable):

    • Add erc7710WalletActions, erc7710BundlerActions, and erc7715ProviderActions in packages/smart-accounts-kit/src/actions/index.ts.
    • Implement sendTransactionWithDelegationAction and sendUserOperationWithDelegationAction (actions/erc7710RedeemDelegationAction.ts).
    • Implement erc7715RequestExecutionPermissionsAction and types (actions/erc7715RequestExecutionPermissionsAction.ts).
    • Export requestExecutionPermissions, related types, and DelegatedCall from actions.
  • Refactors:

    • Update encodeCalls to source DelegatedCall from actions.
    • Remove 7710/7715 action exports from experimental/index.ts (now only delegation storage remains).
  • Tests:

    • Update unit and e2e tests to import from @metamask/smart-accounts-kit/actions instead of experimental.
    • Minor viem change: use createPublicClient in bundler e2e setup.
  • Docs:

    • Replace references to “Delegation Toolkit” with “Smart Accounts Kit” across READMEs and CONTRIBUTING.
  • Breaking change: Consumers must import 7710/7715 actions from @metamask/smart-accounts-kit/actions.

Written by Cursor Bugbot for commit 0abe435. This will update automatically on new commits. Configure here.

@jeffsmale90 jeffsmale90 requested a review from a team as a code owner November 3, 2025 00:06
- import order

@AyushBherwani1998 AyushBherwani1998 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@mj-kiwi mj-kiwi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@jeffsmale90 jeffsmale90 merged commit 3bcd0f4 into main Nov 7, 2025
17 checks passed
@jeffsmale90 jeffsmale90 deleted the feat/promote-permissions-actions branch November 7, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants