Skip to content

Add contributing doc, style guide doc and issue template#102

Merged
V00D00-child merged 7 commits into
mainfrom
feat/add-contributing-doc
Jun 19, 2025
Merged

Add contributing doc, style guide doc and issue template#102
V00D00-child merged 7 commits into
mainfrom
feat/add-contributing-doc

Conversation

@V00D00-child

@V00D00-child V00D00-child commented Jun 12, 2025

Copy link
Copy Markdown
Member

Add:

  • contributing doc
  • style guide doc
  • feature template
  • pull request template
  • bug report template

@V00D00-child V00D00-child requested a review from a team as a code owner June 12, 2025 20:39
@V00D00-child V00D00-child changed the title Add contributing and style guide docs Add contributing doc, style guide doc and issue template Jun 12, 2025
@jeffsmale90 jeffsmale90 requested a review from Copilot June 17, 2025 03:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds baseline project documentation to guide contributors, enforce coding style, and standardize issue submissions.

  • Introduces a comprehensive style guide outlining formatting, naming, and organizational rules.
  • Provides contributing guidelines describing issue/pr workflows and links to security and release docs.
  • Adds a feature-issue template to streamline new feature requests.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
docs/styleGuide.md New coding style guide for formatting, naming, and best practices.
CONTRIBUTING.md Project contribution guidelines and workflow.
.github/ISSUE_TEMPLATE/feature.md Template for creating new feature issues.
Comments suppressed due to low confidence (3)

docs/styleGuide.md:15

  • [nitpick] The guideline specifies camelCase for file names, which contradicts common JS practices of kebab-case; consider aligning file naming conventions with community standards or clarifying when to use camelCase vs kebab-case.
- Use camelCase for file names

CONTRIBUTING.md:3

  • [nitpick] The sentence uses an exclamation mark and includes an article 'the' before the repository name; consider simplifying grammar for clarity, e.g., 'Thank you for contributing to snap-7715-permissions.'
Thank you for your interest in contributing to the `snap-7715-permissions`! Your contributions help make this project better for everyone.

.github/ISSUE_TEMPLATE/feature.md:28

  • The placeholder 'xxxx' should be replaced with an example or instructions indicating how to fill out this section, and ensure consistent bullet indentation for the GIVEN/WHEN/THEN lines.
Scenario: xxxx

@jeffsmale90 jeffsmale90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have an issue template for bugs?

Comment thread docs/styleGuide.md Outdated
Comment thread docs/styleGuide.md Outdated
Comment thread docs/styleGuide.md
V00D00-child and others added 2 commits June 17, 2025 10:12
Co-authored-by: jeffsmale90 <6363749+jeffsmale90@users.noreply.github.com>
@V00D00-child V00D00-child requested a review from jeffsmale90 June 17, 2025 15:16

@jeffsmale90 jeffsmale90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@V00D00-child V00D00-child merged commit 1118b53 into main Jun 19, 2025
15 checks passed
@V00D00-child V00D00-child deleted the feat/add-contributing-doc branch June 19, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants