Ensure justification is sanitised#109
Merged
Merged
Conversation
jeffsmale90
previously approved these changes
Jul 14, 2025
jeffsmale90
left a comment
Contributor
There was a problem hiding this comment.
A couple of nits, plus the shasum mismatch, but this looks great!
jeffsmale90
previously approved these changes
Jul 21, 2025
jeffsmale90
previously approved these changes
Jul 22, 2025
jeffsmale90
left a comment
Contributor
There was a problem hiding this comment.
LGTM - I am unable to test with null justification, as this needs to be integrated into the SDK.
jeffsmale90
previously approved these changes
Jul 25, 2025
jeffsmale90
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Presently any string data provided via justification is rendered verbatim to the confirmation screen, which is a vector for UI redressing
Ensure that justification is sufficiently sanitised before rendering (ideally as early as possible).
The following should be enforced, removed, or sanitized: (plus any other necessary validation or sanitisation)
Maximum length
Control characters
JSON or XML
Excessive whitespace
single or double quotes
In case of null/empty justification use default text: No justification was provided for the permission
With Zod we do strict sanitation of Justification hitting all the UI redressing vectors, scripts, zero-width characters, dangerous protocols are mod.
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist