-
-
Notifications
You must be signed in to change notification settings - Fork 8
New Crowdin translations by Github Action #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fa831d7 to
8bf31a0
Compare
0485788 to
dce42f2
Compare
2cdaccc to
9714208
Compare
dad2499 to
d02fb7b
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Japanese locale file incorrectly identified as English
The ja_JP.json locale file has "locale": "en" instead of "locale": "ja". This causes the Japanese translations to be misidentified as English, which will likely break localization for Japanese users since the internationalization system will treat Japanese content as English content.
28666cb to
d1bf83d
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Japanese locale file declares wrong locale value
The ja_JP.json file contains Japanese translations but incorrectly sets "locale": "en" instead of "locale": "ja". This mismatch between the locale identifier and the actual translation content could cause the application to incorrectly identify or use this locale file, potentially resulting in Japanese users seeing unexpected behavior or the locale not being properly recognized.
d1bf83d to
2e5fc5a
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Japanese locale file has wrong locale identifier
The Japanese locale file ja_JP.json sets "locale": "en" but contains Japanese translations. This causes the system to incorrectly identify this file as English instead of Japanese, preventing Japanese users from seeing the correct translations when using the ja_JP locale variant. The value should be "ja" to match other Japanese locale files.
7652abb to
80f0b15
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Japanese locale file incorrectly identifies as English
The ja_JP.json translation file has its locale value set to "en" instead of "ja", despite containing Japanese translations. The existing ja.json correctly uses "locale": "ja". This mismatch will cause the localization system to incorrectly identify this file as English, meaning Japanese users would not see these translations.
80f0b15 to
365f448
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Japanese locale file has wrong locale identifier
The ja_JP.json file contains Japanese translations but has "locale": "en" instead of "locale": "ja". This mismatch between the locale identifier and the actual content (Japanese messages) could cause the application to incorrectly identify this file's language or fail locale-matching logic. The existing ja.json file correctly uses "locale": "ja", so this appears to be an error in the Crowdin translation automation.
365f448 to
70317fe
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Japanese locale file has wrong locale identifier
The Japanese translation file ja_JP.json has "locale": "en" instead of "locale": "ja". This mismatch means the localization system will likely identify this file as English rather than Japanese, causing Japanese users to not see the Japanese translations despite the file containing properly translated Japanese text.
43999b8 to
a628eb9
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Japanese locale file incorrectly specifies English locale
Medium Severity
The ja_JP.json file has "locale": "en" but contains Japanese translations. The existing ja.json file correctly uses "locale": "ja". This mismatch could cause the localization system to treat Japanese translations as English, potentially resulting in Japanese users not seeing the correct localized content or causing locale resolution issues.
a628eb9 to
229593f
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Japanese locale file incorrectly identifies as English
Medium Severity
The ja_JP.json file contains Japanese translations but declares "locale": "en" instead of "locale": "ja". This mismatch causes the Japanese locale file to be incorrectly identified as English, which will break localization for Japanese users. The existing ja.json file correctly uses "locale": "ja".
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "locale": "es_419", | |||
| "locale": "es", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate locale identifier after Spanish locale change
Medium Severity
The locale value in es_419.json was changed from "es_419" to "es", but es.json already uses "locale": "es". This creates duplicate locale identifiers where two different files both declare themselves as the es locale. This could cause locale resolution conflicts, where the localization system may unpredictably choose between the two files for Spanish speakers, potentially serving the wrong regional variant.
229593f to
fc9b9ee
Compare
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "locale": "es_419", | |||
| "locale": "es", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate locale identifier after changing es_419 to es
Medium Severity
The locale identifier in es_419.json was changed from "es_419" to "es", but a separate es.json file already exists with "locale": "es". This creates duplicate locale identifiers, which could cause the localization system to incorrectly select between generic Spanish and Latin American Spanish (the 419 in the filename refers to the UN M.49 code for Latin America). Additionally, the filename es_419.json now mismatches its internal locale value.
fc9b9ee to
bfe9d7b
Compare
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "locale": "es_419", | |||
| "locale": "es", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latin American Spanish locale identifier incorrectly changed
Low Severity
The locale field in es_419.json was changed from "es_419" to "es", removing the Latin American Spanish regional specificity. This creates an inconsistency since pt_BR.json in the same PR correctly preserves its regional identifier as "pt-BR". If the application uses the locale field to distinguish between Spanish regional variants (e.g., Latin American vs. European Spanish), this change could cause incorrect locale resolution for Latin American Spanish users.
🔬 Verification Test
Why verification test was not possible: This is a data/configuration change in a JSON locale file. The bug is evident from direct inspection of the diff - the locale value was explicitly changed from "es_419" (the IETF language tag for Latin American Spanish) to "es" (generic Spanish), which removes regional specificity that may be needed for proper locale matching.
89863b2 to
a4b0346
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Japanese locale file has wrong locale identifier
High Severity
The ja_JP.json locale file has "locale": "en" instead of "locale": "ja". This causes the Japanese locale to incorrectly identify itself as English. The existing ja.json file correctly uses "locale": "ja". This mismatch could cause the localization system to fail to recognize the file as Japanese, resulting in Japanese users seeing incorrect language content or fallback behavior.
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "locale": "es_419", | |||
| "locale": "es", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate locale identifier for Spanish locale files
Medium Severity
The es_419.json file had its locale field changed from "es_419" to "es". However, es.json already uses "locale": "es". This creates duplicate locale identifiers, which could cause the localization system to use the wrong file or exhibit undefined behavior when resolving Spanish translations. Latin American Spanish users may not receive the correct regional translations.
a4b0346 to
29bb9ee
Compare
Note
Expands localization coverage for the snap UI and errors.
de_DE,el_GR,en_GB,fr_FR,hi_IN,id_ID,ja_JP,ko_KR,pt_BR,ru_RU,tl_PH,tr_TR,vi_VNes_419.json→eslocale and minor string adjustments (e.g.,"Máx."); addserror.3100zh_CNwith additional error code messages (error.*)Written by Cursor Bugbot for commit 29bb9ee. This will update automatically on new commits. Configure here.