[NNT-395] feat: pass origin param to blockaid#395
Merged
Conversation
aganglada
reviewed
May 28, 2025
aganglada
reviewed
May 28, 2025
aganglada
left a comment
aganglada
left a comment
Contributor
There was a problem hiding this comment.
We need to get a newer version of the keyring in order to get the origin from it
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
@SocketSecurity ignore-all |
zone-live
commented
May 29, 2025
zone-live
commented
May 29, 2025
aganglada
reviewed
May 29, 2025
aganglada
changed the title
Contributor
|
Blocked until controllers are bumped on the client |
ulissesferreira
force-pushed
the
NNT-395-pass-origin-to-blockaid
branch
3 times, most recently
from
4fde79a to
94c249c
Compare
ulissesferreira
force-pushed
the
NNT-395-pass-origin-to-blockaid
branch
from
94c249c to
8f1b2ea
Compare
ulissesferreira
changed the title
ulissesferreira
changed the title
ulissesferreira
changed the title
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net> Co-authored-by: Alejandro Garcia Anglada <aganglada@gmail.com>
ulissesferreira
force-pushed
the
NNT-395-pass-origin-to-blockaid
branch
from
a047ed2 to
4bc94a0
Compare
aganglada
approved these changes
Jun 5, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes the
originparam to thescanTransactionsmethod fromSecurityAlertsApiClientand removes the hardcoded value.Ex with Raydium
