chore: adds snap_trackEvent and origin param#418

Merged

zone-live merged 26 commits into

mainfrom

NNT-406-track-events-snap_trackEvent

Jun 18, 2025

zone-live commented Jun 12, 2025 •

edited

Loading

Contributor

We are adding the snap_trackEvent to the AnalyticsService and passing the origin param to each tracked event.

zone-live added 5 commits

June 12, 2025 13:26


          chore: adds snap_trackEvent and origin param

bcf5b87


          chore: lint and prettier

13806e1


          chore: shasum

95b44ee


          chore: adds tests for AnalyticsService

71f04fd


          chore: adds eslint-disable

b715893

zone-live marked this pull request as ready for review

June 12, 2025 14:33

This comment was marked as outdated.

Sign in to view


          chore: adds nullable for origin

e6a6c07

This comment was marked as outdated.

Sign in to view


          chore: prettier

4d5e30e

This comment was marked as outdated.

Sign in to view


          chore: shasum

2a8f57a

This comment was marked as outdated.

Sign in to view

aganglada reviewed

View reviewed changes

packages/snap/src/core/handlers/onCronjob/backgroundEvents/onTransactionSubmitted.ts Outdated


          chore: adds the metadata object

00f79cf

This comment was marked as outdated.

Sign in to view

zone-live and others added 3 commits

June 13, 2025 15:13


          chore: clean up

1a29767


          Merge branch 'main' into NNT-406-track-events-snap_trackEvent

dcdcdbd


          chore: shasum

aa38f8b

This comment was marked as outdated.

Sign in to view


          Merge branch 'NNT-406-track-events-snap_trackEvent' of github.com:Met…

330d601

…aMask/snap-solana-wallet into NNT-406-track-events-snap_trackEvent

This comment was marked as outdated.

Sign in to view


          chore: fix

af4b98d

This comment was marked as outdated.

Sign in to view


          chore: shasum

This comment was marked as outdated.

Sign in to view

aganglada reviewed

View reviewed changes

packages/snap/src/core/handlers/onClientRequest/ClientRequestHandler.ts Outdated

zone-live added 3 commits

June 17, 2025 14:36


          chore: update value to be 'metamask'

dd4e160


          chore: shasum

ada31f6


          chore: adds the METAMASK_ORIGIN

8aee9ae

zone-live and others added 4 commits

June 17, 2025 15:19


          chore: shasum

bb5a22f


          chore: clean up from null values

c3e461f


          chore: update test

2dc8c19


          Merge branch 'main' into NNT-406-track-events-snap_trackEvent

771c5f7

aganglada previously approved these changes

View reviewed changes

zone-live added 2 commits

June 17, 2025 15:57


          chore: shasum update

92efdd5


          Merge branch 'NNT-406-track-events-snap_trackEvent' of github.com:Met…

acd8565

…aMask/snap-solana-wallet into NNT-406-track-events-snap_trackEvent

zone-live dismissed aganglada’s stale review via

acd8565

June 17, 2025 14:58

zone-live requested a review from aganglada

June 18, 2025 08:24

aganglada reviewed

View reviewed changes

packages/snap/src/features/send/views/TransactionConfirmation/events.tsx Outdated

                     account,
                     transactionMessage,
                     scope,
+                    'metamask',

aganglada Jun 18, 2025

Contributor

you are importing METAMASK_ORIGIN in this file

zone-live Jun 18, 2025

Contributor Author

🤦🏼‍♂️ slipped away

zone-live added 2 commits

June 18, 2025 09:40


          chore: quick fix

59106b5


          chore: shasum update

043627a

sonarqubecloud Bot commented Jun 18, 2025

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.2% Coverage on New Code
6.9% Duplication on New Code

See analysis details on SonarQube Cloud

aganglada approved these changes

View reviewed changes

zone-live merged commit 50877de into main

9 checks passed

zone-live deleted the NNT-406-track-events-snap_trackEvent branch

June 18, 2025 08:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet