feat: support NFT assets

.github/workflows/build-lint-test.yml

@@ -29,6 +29,8 @@ on:
         required: true
       SECURITY_ALERTS_API_BASE_URL:
         required: true
+      NFT_API_BASE_URL:
+        required: true
       EXPLORER_BASE_URL:
         required: true
 
@@ -65,6 +67,7 @@ jobs:
       TOKEN_API_BASE_URL: ${{ secrets.TOKEN_API_BASE_URL }}
       STATIC_API_BASE_URL: ${{ secrets.STATIC_API_BASE_URL }}
       SECURITY_ALERTS_API_BASE_URL: ${{ secrets.SECURITY_ALERTS_API_BASE_URL }}
+      NFT_API_BASE_URL: ${{ secrets.NFT_API_BASE_URL }}
     steps:
       - name: Checkout and setup environment
         uses: MetaMask/action-checkout-and-setup@v1
@@ -116,6 +119,7 @@ jobs:
       TOKEN_API_BASE_URL: ${{ secrets.TOKEN_API_BASE_URL }}
       STATIC_API_BASE_URL: ${{ secrets.STATIC_API_BASE_URL }}
       SECURITY_ALERTS_API_BASE_URL: ${{ secrets.SECURITY_ALERTS_API_BASE_URL }}
+      NFT_API_BASE_URL: ${{ secrets.NFT_API_BASE_URL }}
     steps:
       - name: Checkout and setup environment
         uses: MetaMask/action-checkout-and-setup@v1

.github/workflows/create-release-pr.yml

@@ -69,3 +69,4 @@ jobs:
           TOKEN_API_BASE_URL: ${{ secrets.TOKEN_API_BASE_URL }}
           STATIC_API_BASE_URL: ${{ secrets.STATIC_API_BASE_URL }}
           SECURITY_ALERTS_API_BASE_URL: ${{ secrets.SECURITY_ALERTS_API_BASE_URL }}
+          NFT_API_BASE_URL: ${{ secrets.NFT_API_BASE_URL }}

.github/workflows/main.yml

@@ -23,6 +23,7 @@ jobs:
       TOKEN_API_BASE_URL: ${{ secrets.TOKEN_API_BASE_URL }}
       STATIC_API_BASE_URL: ${{ secrets.STATIC_API_BASE_URL }}
       SECURITY_ALERTS_API_BASE_URL: ${{ secrets.SECURITY_ALERTS_API_BASE_URL }}
+      NFT_API_BASE_URL: ${{ secrets.NFT_API_BASE_URL }}
 
   sonarcloud:
     permissions:
@@ -101,3 +102,4 @@ jobs:
       TOKEN_API_BASE_URL: ${{ secrets.TOKEN_API_BASE_URL }}
       STATIC_API_BASE_URL: ${{ secrets.STATIC_API_BASE_URL }}
       SECURITY_ALERTS_API_BASE_URL: ${{ secrets.SECURITY_ALERTS_API_BASE_URL }}
+      NFT_API_BASE_URL: ${{ secrets.NFT_API_BASE_URL }}

.github/workflows/pr.yml

@@ -37,6 +37,7 @@ jobs:
       TOKEN_API_BASE_URL: ${{ secrets.TOKEN_API_BASE_URL }}
       STATIC_API_BASE_URL: ${{ secrets.STATIC_API_BASE_URL }}
       SECURITY_ALERTS_API_BASE_URL: ${{ secrets.SECURITY_ALERTS_API_BASE_URL }}
+      NFT_API_BASE_URL: ${{ secrets.NFT_API_BASE_URL }}
 
   sonarcloud:
     permissions:

.github/workflows/publish-release.yml

@@ -33,6 +33,8 @@ on:
         required: true
       SECURITY_ALERTS_API_BASE_URL:
         required: true
+      NFT_API_BASE_URL:
+        required: true
       EXPLORER_BASE_URL:
         required: true
 jobs:
@@ -69,6 +71,7 @@ jobs:
           TOKEN_API_BASE_URL: ${{ secrets.TOKEN_API_BASE_URL }}
           STATIC_API_BASE_URL: ${{ secrets.STATIC_API_BASE_URL }}
           SECURITY_ALERTS_API_BASE_URL: ${{ secrets.SECURITY_ALERTS_API_BASE_URL }}
+          NFT_API_BASE_URL: ${{ secrets.NFT_API_BASE_URL }}
       - name: Upload build artifacts
         uses: actions/upload-artifact@v4
         with:

packages/snap/locales/de.json

@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}

packages/snap/locales/el.json

@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}

packages/snap/locales/es.json

@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}

packages/snap/locales/fr.json

@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}

packages/snap/locales/hi.json

@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}

packages/snap/locales/id.json

@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}

packages/snap/locales/ja.json

@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}

packages/snap/locales/ko.json

@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}

packages/snap/locales/pt.json

@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}

packages/snap/locales/ru.json

@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}

packages/snap/locales/tl.json

@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}

packages/snap/locales/tr.json

@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}

packages/snap/locales/vi.json

@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}

packages/snap/locales/zh.json

@@ -266,4 +266,4 @@
       "message": "An unknown error occurred."
     }
   }
-}
+}

packages/snap/snap.config.ts

@@ -20,6 +20,7 @@ const environment = {
   TOKEN_API_BASE_URL: process.env.TOKEN_API_BASE_URL ?? '',
   STATIC_API_BASE_URL: process.env.STATIC_API_BASE_URL ?? '',
   SECURITY_ALERTS_API_BASE_URL: process.env.SECURITY_ALERTS_API_BASE_URL ?? '',
+  NFT_API_BASE_URL: process.env.NFT_API_BASE_URL ?? '',
   LOCAL_API_BASE_URL: process.env.LOCAL_API_BASE_URL ?? '',
 };
 

packages/snap/snap.manifest.json

@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snap-solana-wallet.git"
   },
   "source": {
-    "shasum": "60Zn2UOhpoaLT3yQ5V8UJElF7SiGynw9+dQ9lfZICFQ=",
+    "shasum": "+7X37iftHlIqWFoG3QMA+Cro5+l3gv2VJQdBmuBnU6I=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",

packages/snap/src/core/clients/nft-api/NftApiClient.test.ts

@@ -0,0 +1,154 @@
+/* eslint-disable @typescript-eslint/naming-convention */
+import type { ICache } from '../../caching/ICache';
+import { InMemoryCache } from '../../caching/InMemoryCache';
+import type { Serializable } from '../../serialization/types';
+import type { ConfigProvider } from '../../services/config';
+import type { ILogger } from '../../utils/logger';
+import { MOCK_NFT_METADATA_RESPONSE_MAPPED } from './mocks/mockNftMetadataResponseMapped';
+import { MOCK_NFT_METADATA_RESPONSE_RAW } from './mocks/mockNftMetadataResponseRaw';
+import { MOCK_NFTS_LIST_RESPONSE_MAPPED } from './mocks/mockNftsListResponseMapped';
+import { MOCK_NFTS_LIST_RESPONSE_RAW } from './mocks/mockNftsListResponseRaw';
+import { NftApiClient } from './NftApiClient';
+
+const mockFetch = jest.fn();
+const mockLogger = {
+  info: jest.fn(console.info),
+  error: jest.fn(console.error),
+  warn: jest.fn(console.error),
+} as unknown as ILogger;
+let mockCache: ICache<Serializable>;
+
+describe('NftApiClient', () => {
+  let client: NftApiClient;
+  let mockConfigProvider: ConfigProvider;
+
+  beforeEach(() => {
+    jest.clearAllMocks();
+
+    mockCache = new InMemoryCache(mockLogger);
+
+    mockConfigProvider = {
+      get: jest.fn().mockReturnValue({
+        nftApi: {
+          baseUrl: 'https://some-mock-url.com',
+          cacheTtlsMilliseconds: {
+            listAddressSolanaNfts: 0,
+            getNftMetadata: 0,
+          },
+        },
+      }),
+    } as unknown as ConfigProvider;
+
+    client = new NftApiClient(
+      mockConfigProvider,
+      mockCache,
+      mockFetch,
+      mockLogger,
+    );
+  });
+
+  describe('constructor', () => {
+    it('rejects invalid baseUrl', async () => {
+      const invalidConfigProvider = {
+        get: jest.fn().mockReturnValue({
+          nftApi: {
+            baseUrl: 'invalid-url',
+            cacheTtlsMilliseconds: {
+              listAddressSolanaNfts: 0,
+              getNftMetadata: 0,
+            },
+          },
+        }),
+      } as unknown as ConfigProvider;
+
+      expect(
+        () =>
+          new NftApiClient(
+            invalidConfigProvider,
+            mockCache,
+            mockFetch,
+            mockLogger,
+          ),
+      ).toThrow('Invalid URL format');
+    });
+  });
+
+  describe('listAddressSolanaNfts', () => {
+    it('should correctly map the API response, covering the logic from mapListAddressSolanaNftsResponse.test.ts', async () => {
+      mockFetch.mockResolvedValueOnce({
+        ok: true,
+        json: jest.fn().mockResolvedValueOnce({
+          ...MOCK_NFTS_LIST_RESPONSE_RAW,
+          cursor: null,
+        }),
+      });
+
+      const nfts = await client.listAddressSolanaNfts('some-address');
+      expect(nfts).toStrictEqual(MOCK_NFTS_LIST_RESPONSE_MAPPED.items);
+    });
+
+    it('should handle pagination', async () => {
+      const MOCK_NFTS_LIST_RESPONSE_RAW_PAGE_1 = {
+        ...MOCK_NFTS_LIST_RESPONSE_RAW,
+        cursor: 'some-cursor',
+      };
+      const MOCK_NFTS_LIST_RESPONSE_RAW_PAGE_2 = {
+        ...MOCK_NFTS_LIST_RESPONSE_RAW,
+        cursor: null,
+      };
+      mockFetch.mockResolvedValueOnce({
+        ok: true,
+        json: jest
+          .fn()
+          .mockResolvedValueOnce(MOCK_NFTS_LIST_RESPONSE_RAW_PAGE_1),
+      });
+      mockFetch.mockResolvedValueOnce({
+        ok: true,
+        json: jest
+          .fn()
+          .mockResolvedValueOnce(MOCK_NFTS_LIST_RESPONSE_RAW_PAGE_2),
+      });
+      const nfts = await client.listAddressSolanaNfts('some-address');
+      expect(nfts).toStrictEqual([
+        ...MOCK_NFTS_LIST_RESPONSE_MAPPED.items,
+        ...MOCK_NFTS_LIST_RESPONSE_MAPPED.items,
+      ]);
+      expect(mockFetch).toHaveBeenCalledTimes(2);
+    });
+  });
+
+  describe('getNftMetadata', () => {
+    it('should fetch and parse solana nft metadata for a given token address', async () => {
+      mockFetch.mockResolvedValueOnce({
+        ok: true,
+        json: jest.fn().mockResolvedValueOnce(MOCK_NFT_METADATA_RESPONSE_RAW),
+      });
+      const nft = await client.getNftMetadata('some-token-address');
+      expect(nft).toStrictEqual(MOCK_NFT_METADATA_RESPONSE_MAPPED);
+    });
+
+    it('should return null if the fetch fails', async () => {
+      mockFetch.mockRejectedValueOnce(new Error('some-error'));
+      const nft = await client.getNftMetadata('some-token-address');
+      expect(nft).toBeNull();
+    });
+  });
+
+  describe('getNftsMetadata', () => {
+    it('should fetch and parse solana nft metadata for a given array of token addresses', async () => {
+      mockFetch.mockResolvedValue({
+        ok: true,
+        json: jest.fn().mockResolvedValue(MOCK_NFT_METADATA_RESPONSE_RAW),
+      });
+      const nfts = await client.getNftsMetadata([
+        'some-token-address-1',
+        'some-token-address-2',
+      ]);
+      expect(nfts).toStrictEqual([
+        MOCK_NFT_METADATA_RESPONSE_MAPPED,
+        MOCK_NFT_METADATA_RESPONSE_MAPPED,
+      ]);
+      expect(mockFetch).toHaveBeenCalledTimes(2);
+    });
+  });
+});