feat: integrate sns

[aganglada]

• Integrate SNS in onNameLookup
• Resolve domains on the Send flow

Not in scope:

• Showing .sol domain in confirmations (There is a Snap UI limitation right now)

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​solana-name-service/​sns-sdk-kit@​0.9.0-beta

View full report

[cursor]

Bug: Domain Resolution Error Not Handled

The if (destinationValidation === null) condition checks the initial format validation result, not the final state after domain resolution. If a syntactically valid .sol domain fails to resolve, destinationValidation remains null while updatedContext.validation[SendFormNames.DestinationAccountInput] is updated with an error. This leads to buildTransactionMessageAndUpdateInterface being called with an unresolved domain. The condition should check updatedContext.validation[SendFormNames.DestinationAccountInput] === null.

packages/snap/src/features/send/views/SendForm/events.tsx#L400-L404

snap-solana-wallet/packages/snap/src/features/send/views/SendForm/events.tsx

Lines 400 to 404 in d8053a8

	await updateInterface(id, <Send context={updatedContext} />, updatedContext);
	if (destinationValidation === null) {
	await buildTransactionMessageAndUpdateInterface(id, updatedContext);
	}

Fix in Cursor

---

Bug: Incorrect Domain Resolution in `resolveAddress` Method

The resolveAddress method incorrectly returns domainAddress from the getPrimaryDomain result. Intended to resolve an address to its domain name, it should return domainName. Returning domainAddress is semantically incorrect and likely stems from a misunderstanding of the external library API.

packages/snap/src/core/services/name-resolution/NameResolutionService.ts#L22-L27

snap-solana-wallet/packages/snap/src/core/services/name-resolution/NameResolutionService.ts

Lines 22 to 27 in d8053a8

	async resolveAddress(scope: Network, address: string): Promise<string> {
	const connection = this.#connection.getRpc(scope);
	return (await getPrimaryDomain(connection, asAddress(address)))
	.domainAddress;
	}

Fix in Cursor

---

Was this report helpful? Give feedback by reacting with 👍 or 👎

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud