Conversation
Contributor
Author
|
This fixes MetaMask/metamask-extension#33522 |
Contributor
Author
|
Closing in favor of #563 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes all the uses of window.ethereum and related tests. I have tested locally and with this change, I can have Phantom and MetaMask running simultaneously and only MetaMask responds to requests. I am not 100% certain that there are no other side effects. This may require more testing.
Video of this working:
Screen.Recording.2025-06-10.at.4.57.16.PM.mov