fix: Disable base64 optimization in ReactNative#3564
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Mrtenz
reviewed
Aug 7, 2025
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
GuillaumeRx
previously approved these changes
Aug 7, 2025
Mrtenz
previously approved these changes
Aug 7, 2025
GuillaumeRx
previously approved these changes
Aug 7, 2025
FrederikBolding
dismissed stale reviews from GuillaumeRx and Mrtenz
via
a4b2363
GuillaumeRx
approved these changes
Aug 7, 2025
Mrtenz
approved these changes
Aug 7, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3564 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 417 417
Lines 11764 11765 +1
Branches 1829 1830 +1
=======================================
+ Hits 11562 11563 +1
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our base64 encoding optimization does not run in React Native, because React Native doesn't support creating Files/Blobs from buffers.