Skip to content

fix: Only log error that originally caused the crash#3569

Merged
FrederikBolding merged 1 commit into
mainfrom
fb/only-log-error-that-caused-crash
Aug 11, 2025
Merged

fix: Only log error that originally caused the crash#3569
FrederikBolding merged 1 commit into
mainfrom
fb/only-log-error-that-caused-crash

Conversation

@FrederikBolding

Copy link
Copy Markdown
Member

The crash logging that we recently added would trigger for any unhandled error, including cancelled requests during a crash. This PR only logs the original crash error.

@FrederikBolding FrederikBolding requested a review from a team as a code owner August 11, 2025 10:02
Comment thread packages/snaps-controllers/src/snaps/SnapController.ts
@codecov

codecov Bot commented Aug 11, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.28%. Comparing base (235feed) to head (ba97ff5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3569   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         417      417           
  Lines       11769    11771    +2     
  Branches     1830     1832    +2     
=======================================
+ Hits        11567    11569    +2     
  Misses        202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue Aug 11, 2025
Merged via the queue into main with commit 786718a Aug 11, 2025
120 checks passed
@FrederikBolding FrederikBolding deleted the fb/only-log-error-that-caused-crash branch August 11, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants