-
Notifications
You must be signed in to change notification settings - Fork 637
chore: Bump @metamask/eslint-config-nodejs from 14.0.0 to 15.0.0 #3765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: Bump @metamask/eslint-config-nodejs from 14.0.0 to 15.0.0 #3765
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| "@metamask/eslint-config-browser": "^14.0.0", | ||
| "@metamask/eslint-config-jest": "^14.0.0", | ||
| "@metamask/eslint-config-nodejs": "^14.0.0", | ||
| "@metamask/eslint-config-nodejs": "^15.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Peer dependency mismatch with @metamask/eslint-config version
The @metamask/eslint-config-nodejs package is upgraded to ^15.0.0, which requires @metamask/eslint-config: ^15.0.0 as a peer dependency (visible in the yarn.lock). However, @metamask/eslint-config remains at ^14.0.0 in the devDependencies. This peer dependency mismatch will cause yarn to report warnings/errors and may lead to ESLint configuration conflicts or unexpected linting behavior.
Additional Locations (2)
Bumps [@metamask/eslint-config-nodejs](https://github.com/MetaMask/eslint-config) from 14.0.0 to 15.0.0. - [Release notes](https://github.com/MetaMask/eslint-config/releases) - [Commits](https://github.com/MetaMask/eslint-config/compare/@metamask/[email protected]...@metamask/[email protected]) --- updated-dependencies: - dependency-name: "@metamask/eslint-config-nodejs" dependency-version: 15.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
8d31652 to
f8fb2d8
Compare
| "@metamask/eslint-config-browser": "^14.0.0", | ||
| "@metamask/eslint-config-jest": "^14.0.0", | ||
| "@metamask/eslint-config-nodejs": "^14.0.0", | ||
| "@metamask/eslint-config-nodejs": "^15.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Peer dependency version mismatch for eslint-config-nodejs
@metamask/[email protected] requires @metamask/eslint-config@^15.0.0 as a peer dependency, but the project still has @metamask/eslint-config@^14.0.0 installed. This is documented as a breaking change in the release notes. The unmet peer dependency could cause yarn warnings, configuration conflicts, or unexpected ESLint behavior. The base @metamask/eslint-config package needs to also be updated to ^15.0.0.
Bumps @metamask/eslint-config-nodejs from 14.0.0 to 15.0.0.
Release notes
Sourced from
@metamask/eslint-config-nodejs's releases.... (truncated)
Commits
0b8cf6dRelease/15.0.0 (#431)9568eb3fix: Disablejsdoc/check-indentationto fix bullet list formatting (#430)7837174feat: Loosen@typescript-eslint/naming-conventionfor object literal proper...cf93ef1fix: Disableimport-x/no-duplicatesin TypeScript files (#427)f3246f7chore: Disable redudant lint rule (#425)383fbecfeat: Disable@typescript-eslint/no-unnecessary-type-arguments(#426)a0e0bc8feat: Convert all warnings to errors (#424)b243e90chore: Increase minimumtypescript-eslintversion (#423)b116974Allow remaining TypeScript 5.x versions (#422)c70a3ffBREAKING: Updatejsdoc/require-jsdocto require documentation for more thin...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Upgrade @metamask/eslint-config-nodejs dev dependency to v15 and refresh yarn.lock.
@metamask/eslint-config-nodejsfrom^14.0.0to^15.0.0inpackage.json.yarn.lockto resolve to@metamask/[email protected]with updated peer dependency metadata.Written by Cursor Bugbot for commit f8fb2d8. This will update automatically on new commits. Configure here.