feat!: Use StorageService to store source code
#3777
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Mrtenz
reviewed
Dec 16, 2025
Comment on lines
4678
to
4682
| const { result } = await this.messenger.call( | ||
| 'StorageService:getItem', | ||
| this.name, | ||
| snapId, | ||
| ); |
Member
There was a problem hiding this comment.
In case we want to add other properties in the future, should this be an object containing sourceCode?
Contributor
Author
There was a problem hiding this comment.
I thought about this and it's in my list of improvements. I wanted to validate the approach first :)
| * @returns The source code for the snap. | ||
| */ | ||
| async #getSourceCode(snapId: SnapId) { | ||
| const { result } = await this.messenger.call( |
Member
There was a problem hiding this comment.
Can the usage of the StorageService throw?
Contributor
Author
There was a problem hiding this comment.
not for getItem
GuillaumeRx
force-pushed
the
gr/storage-service
branch
from
57095fe to
6a20e47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WORK IN PROGRESS]
This PR adds the use of
StorageServiceto store the Snap source codes. Due to this storage being async, theSnapControllerinitialization is now async and the preinstalled snaps setup now lives ininit()