Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Dec 19, 2025

This adds a new action which determines whether a pull request in the merge queue is up-to-date, meaning:

  • The pull request is based on the latest commit on main.
  • The pull request is the first in the merge queue.

In this case, all status checks have already passed on the branch, and running in the merge queue would be redundant, meaning we can skip the merge queue checks.


Note

Adds a job to detect up-to-date PRs in merge groups and conditionally skip subsequent checks, adjusting dependencies and final pass gating accordingly.

  • CI Workflow (.github/workflows/main.yml)
    • New job: check-skip-merge-queue to detect up-to-date PRs during merge_group using MetaMask/github-tools/.../check-skip-merge-queue@v1.
    • Conditional execution: check-workflows now needs: check-skip-merge-queue and is skipped in merge_group when skip-merge-queue is true.
    • Final gating: all-jobs-pass now depends on both all-jobs-complete and check-skip-merge-queue, passing if either all jobs passed or skip-merge-queue is true.
    • Minor wiring: checkout only during merge_group for the new job; propagate skip-merge-queue via job outputs.

Written by Cursor Bugbot for commit 390987f. This will update automatically on new commits. Configure here.

@Mrtenz Mrtenz marked this pull request as ready for review December 19, 2025 10:36
@Mrtenz Mrtenz requested a review from a team as a code owner December 19, 2025 10:36
@Mrtenz Mrtenz force-pushed the mrtenz/skip-merge-queue branch from 7bced5e to 390987f Compare December 19, 2025 10:36
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.33%. Comparing base (3624460) to head (390987f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3786   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files         420      420           
  Lines       12032    12032           
  Branches     1874     1874           
=======================================
  Hits        11832    11832           
  Misses        200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mrtenz Mrtenz added this pull request to the merge queue Dec 19, 2025
Merged via the queue into main with commit b540ee6 Dec 19, 2025
128 checks passed
@Mrtenz Mrtenz deleted the mrtenz/skip-merge-queue branch December 19, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants