Skip to content

ci: use token-exchange-service to publish docs#40

Merged
ccharly merged 6 commits into
mainfrom
ci/feat/publish-docs
Jul 2, 2026
Merged

ci: use token-exchange-service to publish docs#40
ccharly merged 6 commits into
mainfrom
ci/feat/publish-docs

Conversation

@ccharly

@ccharly ccharly commented Jul 1, 2026

Copy link
Copy Markdown

Note

Medium Risk
Changes how CI authenticates to push gh-pages; misconfigured TOKEN_EXCHANGE_URL or exchange permissions would break doc publishes, though scope is limited to documentation deployment.

Overview
GitHub Pages doc publishing now gets a short-lived contents: write token from MetaMask’s token-exchange flow (get-token + vars.TOKEN_EXCHANGE_URL) instead of wiring PUBLISH_DOCS_TOKEN straight into peaceiris/actions-gh-pages.

Workflow permissions are tightened: callers and the reusable publish-docs job drop default contents: write in favor of contents: read plus id-token: write so OIDC can run; only the token step asks for write access. The reusable workflow no longer documents the per-environment PAT setup for deploy (that comment is removed).

Note: publish-docs.yml still declares PUBLISH_DOCS_TOKEN as a required callable secret and parent workflows still pass it, but deploy no longer consumes it—likely leftover until a follow-up cleanup.

Reviewed by Cursor Bugbot for commit 8e04ad7. Bugbot is set up for automated code reviews on this repo. Configure here.

@ccharly ccharly requested a review from a team as a code owner July 1, 2026 16:01

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8b435fa. Configure here.

Comment thread .github/workflows/publish-docs.yml
@ccharly ccharly enabled auto-merge (squash) July 1, 2026 16:43
Mrtenz
Mrtenz previously approved these changes Jul 1, 2026
@ccharly ccharly disabled auto-merge July 1, 2026 17:05
@ccharly ccharly enabled auto-merge (squash) July 1, 2026 17:05
@ccharly ccharly merged commit 37f9873 into main Jul 2, 2026
22 checks passed
@ccharly ccharly deleted the ci/feat/publish-docs branch July 2, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants