Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implemented page for sprint 2 and 3 #29

Merged
merged 10 commits into from
Feb 14, 2024
Merged

feat: implemented page for sprint 2 and 3 #29

merged 10 commits into from
Feb 14, 2024

Conversation

yaslam-dev
Copy link
Collaborator

@yaslam-dev yaslam-dev commented Feb 2, 2024

Changes

  1. Using Webpack instead of tsc to transpile code.
  2. Using Nodemon for HMR.
  3. A few files weren't ignored by the vscode package; it's fixed now.
  4. Previously we were using global state of vs code to communicate information between webview and extension; Now this is replaced with lightweight event emitter implementation; which can send messages directly to webview thus improving the user experience and reliability of the code.

Missing from this PR that will be addressed in the upcoming PR.

  1. Testcases
  2. By Default extension should inherit the vs-code theme.
  3. Back button on Recommendation Page.
  4. Other files with problems features

Implementation

  1. Sprint 2 and Sprint 3 screens implemented.

@yaslam-dev yaslam-dev changed the title feat: implemented page for sprint 1 feat: implemented page for sprint 2 and 3 Feb 5, 2024
Copy link
Contributor

@AviGopal AviGopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes, these can be addressed in pr #30:

  • There is a 1-2 second delay between clicking 'more details' and the left panel updating
  • Discarding a problem using the 'Discard' button should remove the problem from the left panel (It already removes the highlight) The inconsistency will lead to confusion

Other than those, it looks good. I'll merge it shortly

@yaslam-dev
Copy link
Collaborator Author

@AviGopal Thank you for the review. Above mentioned issues are addressed in PR #30

@AviGopal AviGopal removed the request for review from axellos162 February 14, 2024 19:24
Copy link
Contributor

@AviGopal AviGopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@AviGopal AviGopal merged commit 056c300 into main Feb 14, 2024
1 check passed
@yaslam-dev yaslam-dev deleted the sprint-3 branch February 22, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants