Repository navigation
Remove use of NO_BEGINCONNECT - #1312
Merged
Merged
Conversation
Collaborator
|
need conflict fix |
Carti-it
force-pushed
the
remove-NO_BEGINCONNECT
branch
from
June 11, 2026 06:27
6f9e12c to
6c16a00
Compare
Contributor
Author
|
Done |
Carti-it
commented
Jun 14, 2026
| return socket.ConnectAsync(remoteEP, cancellationToken).AsTask(); | ||
| } | ||
| #elif !NO_BEGINCONNECT | ||
| #else |
Contributor
Author
There was a problem hiding this comment.
The only relevant change is in this file.
Carti-it
force-pushed
the
remove-NO_BEGINCONNECT
branch
from
June 14, 2026 09:36
2930f77 to
0ef8aee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #1311 to avoid conflicts.