Skip to content

Remove use of NO_MEM_BUFFER #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicolasDorier merged 1 commit into from
Sep 7, 2026
Merged

Remove use of NO_MEM_BUFFER #1330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions NBitcoin/Crypto/HashStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,12 +310,7 @@ public override void WriteByte(byte value)

public override uint256 GetHash()
{
#if NO_MEM_BUFFER
var copy = ms.ToArray();
return GetHash(copy, 0, (int)copy.Length);
#else
return GetHash(ms.GetBuffer(), 0, (int)ms.Length);
#endif
}

protected abstract uint256 GetHash(byte[] data, int offset, int length);
Expand Down
4 changes: 0 additions & 4 deletions NBitcoin/IBitcoinSerializable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,9 @@ public static byte[] ToBytes(this IBitcoinSerializable serializable, uint? versi

public static byte[] ToArrayEfficient(this MemoryStream ms)
{
#if NO_MEM_BUFFER
return ms.ToArray();
#else
var bytes = ms.GetBuffer();
Array.Resize(ref bytes, (int)ms.Length);
return bytes;
#endif
}
}
}
Loading