Repository navigation
Fix Dogecoin AuxPoW headers parsing - #1334
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dogecoin serializes entries in
headersmessages as blocks with empty transaction vectors. For AuxPoW blocks this includes the AuxPoW structure between the 80-byte header and the zero transaction count.Parse DOGE headers through the existing
DogecoinBlockserializer so AuxPoW bytes are consumed correctly, while keeping the payload assignable toHeadersPayload. Parsed messages also retain their wire representation for serialization.Adds an offline regression test with hardcoded header bytes and expected hashes.
Fixes the NBitcoin parsing failure reported in btcpayserver/NBXplorer#562:
btcpayserver/NBXplorer#562
Tested with:
dotnet test NBitcoin.Tests/NBitcoin.Tests.csproj --framework net10.0 --filter "Altcoins=Altcoins" --no-restore --verbosity minimal