Repository navigation
Reject non-canonical (leading-zero) numbers in older()/after()/multi() count parsing - #1340
Merged
NicolasDorier merged 2 commits intoSep 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1283
older(),after(), andmulti()'s count parameter accepted numbers with leading zeros (e.g.older(000000002088829000)), which is non-canonical and should be rejected — matching the behavior of other miniscript implementations (bitcoin-core, rust-miniscript).Changes
TryParseParameterCountandTryParseLocktimeinMiniscript.csnow reject any numeric match with a leading zero (length > 1 and first char is '0').RejectsNonCanonicalNumberstheory test covering the issue's repro case plus a few positive/negative cases.