Repository navigation
Remove use of NOSOCKET - #1343
Merged
Merged
Conversation
Carti-it
commented
Sep 25, 2026
|
|
||
| builder.SetConsensus(consensus); | ||
|
|
||
| #if !NOSOCKET |
Contributor
Author
There was a problem hiding this comment.
Correctness of this file can be verified by looking that there are no more #if in this file.
Carti-it
commented
Sep 25, 2026
| @@ -1,5 +1,4 @@ | |||
| #if !NOSOCKET | |||
Contributor
Author
There was a problem hiding this comment.
If #if !NOSOCKET is removed from the first line, then it's safe to remove the last line containing #endif. This is because the whole file was not meant to be compiled for some TFMs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1342
NOSOCKETwas removed in #1243 (commit 4780a7f)