Repository navigation
Harden validation of malformed and inconsistent inputs - #1358
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This hardens several public parsing, signing, and transaction-building paths so malformed or internally inconsistent inputs fail predictably instead of being accepted, misinterpreted, or producing unrelated exceptions.
Compatibility
Callers that previously supplied mismatched extended keys, inconsistent PSBT UTXO records, negative amounts to
Split(), conflicting metadata for one outpoint, or invalid builder indexes will now receive validation errors. Identical coins may still be shared across builder groups, and other valid inputs retain their existing behavior.