Skip to content

Fix DigiByte network parameters #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicolasDorier merged 5 commits into from
Oct 26, 2026
Merged

Fix DigiByte network parameters #1361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d68422
Fix DigiByte network parameters
saltedlolly Oct 16, 2026
f6435fb
Let DigiByte peers accept NBitcoin and enable SegWit/Taproot
saltedlolly Oct 18, 2026
6a27152
Skip DigiByte Taproot address check on .NET Framework
saltedlolly Oct 25, 2026
af49616
Register DigiByte Core's default RPC cookie paths
saltedlolly Oct 25, 2026
90d9b4e
Set DigiByte's 15 second block target spacing
saltedlolly Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 36 additions & 13 deletions NBitcoin.Altcoins/DigiByte.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ public class DigiByte : NetworkSetBase

private DigiByte() { }

protected override void PostInit()
{
RegisterDefaultCookiePath("DigiByte", new FolderName() { TestnetFolder = "testnet26" });
}

protected override NetworkBuilder CreateMainnet()
{
var builder = new NetworkBuilder();
Expand All @@ -22,6 +27,9 @@ protected override NetworkBuilder CreateMainnet()
MajorityEnforceBlockUpgrade = 750,
MajorityRejectBlockOutdated = 950,
MajorityWindow = 1000,
SupportSegwit = true,
SupportTaproot = true,
PowTargetSpacing = System.TimeSpan.FromSeconds(15),
})
.SetBase58Bytes(Base58Type.PUBKEY_ADDRESS, [30])
.SetBase58Bytes(Base58Type.SCRIPT_ADDRESS, [63])
Expand All @@ -30,14 +38,18 @@ protected override NetworkBuilder CreateMainnet()
.SetBase58Bytes(Base58Type.EXT_SECRET_KEY, [0x04, 0x88, 0xAD, 0xE4])
.SetBech32(Bech32Type.WITNESS_PUBKEY_ADDRESS, Encoders.Bech32("dgb"))
.SetBech32(Bech32Type.WITNESS_SCRIPT_ADDRESS, Encoders.Bech32("dgb"))
.SetBech32(Bech32Type.TAPROOT_ADDRESS, Encoders.Bech32("dgb"))
.SetMagic(0xDAB6C3FA)
.SetPort(12024)
.SetRPCPort(14022)
.SetGenesis("0100000000000000000000000000000000000000000000000000000000000000000000003ba3edfd7a7b12b27ac72c3e67768f617fc81bc3888a51323a9fb8aa4b1e5e4a29ab5f49ffff001d1dac2b7c")
.SetMaxP2PVersion(70017) // DigiByte Core MIN_PEER_PROTO_VERSION
.SetGenesis("010000000000000000000000000000000000000000000000000000000000000000000000ad0f7d7518fc1e90ed28bd0e444ccd8e24d94688355705ed2142006b49d9dd726a62d052f0ff0f1e245925000101000000010000000000000000000000000000000000000000000000000000000000000000ffffffff4d04ffff001d01044555534120546f6461793a2031302f4a616e2f323031342c205461726765743a20446174612073746f6c656e2066726f6d20757020746f203131304d20637573746f6d657273ffffffff01401f0000000000000200ac00000000")
.AddDNSSeeds([
new DNSSeedData("seed.digibyte.org", "seed.digibyte.org"),
new DNSSeedData("seed.digibyte.co", "seed.digibyte.co"),
new DNSSeedData("digiexplorer.info", "digiexplorer.info")
new DNSSeedData("seed.digibyte.io", "seed.digibyte.io"),
new DNSSeedData("seed.diginode.tools", "seed.diginode.tools"),
new DNSSeedData("seed.digibyte.link", "seed.digibyte.link"),
new DNSSeedData("seed.aroundtheblock.app", "seed.aroundtheblock.app"),
new DNSSeedData("seed.tuyul.cc", "seed.tuyul.cc")
]);

return builder;
Expand All @@ -54,7 +66,10 @@ protected override NetworkBuilder CreateTestnet()
SubsidyHalvingInterval = 210000,
MajorityEnforceBlockUpgrade = 750,
MajorityRejectBlockOutdated = 950,
MajorityWindow = 1000
MajorityWindow = 1000,
SupportSegwit = true,
SupportTaproot = true,
PowTargetSpacing = System.TimeSpan.FromSeconds(15)
})
.SetBase58Bytes(Base58Type.PUBKEY_ADDRESS, [0x7E]) // tD
.SetBase58Bytes(Base58Type.SCRIPT_ADDRESS, [0x8C]) // tS
Expand All @@ -63,13 +78,16 @@ protected override NetworkBuilder CreateTestnet()
.SetBase58Bytes(Base58Type.EXT_SECRET_KEY, [0x04, 0x35, 0x83, 0x94])
.SetBech32(Bech32Type.WITNESS_PUBKEY_ADDRESS, Encoders.Bech32("dgbt"))
.SetBech32(Bech32Type.WITNESS_SCRIPT_ADDRESS, Encoders.Bech32("dgbt"))
.SetMagic(0xDDB6C3FA)
.SetPort(12026)
.SetRPCPort(14023)
.SetGenesis("0100000000000000000000000000000000000000000000000000000000000000000000003ba3edfd7a7b12b27ac72c3e67768f617fc81bc3888a51323a9fb8aa4b1e5e4a29ab5f49ffff001d1dac2b7c")
.SetBech32(Bech32Type.TAPROOT_ADDRESS, Encoders.Bech32("dgbt"))
.SetMagic(0xE7B9C6FE)
.SetPort(12033)
.SetRPCPort(14026)
.SetMaxP2PVersion(70017) // DigiByte Core MIN_PEER_PROTO_VERSION
.SetGenesis("01000000000000000000000000000000000000000000000000000000000000000000000097c108c537584d093dec35631a8dc487fe01a98226b702c60672476a9fa5ec7680091b6af0ff0f1e899613000101000000010000000000000000000000000000000000000000000000000000000000000000ffffffff4304ffff001d01043b44696769446f6c6c617220546573746e657432363a205243343420372d6f662d3335204f7261636c65205265736574206f6e204469676942797465ffffffff010040b743ba0000000200ac00000000")
.AddDNSSeeds([
new DNSSeedData("seed.testnet-1.us.digibyteservers.io", "seed.testnet-1.us.digibyteservers.io"),
new DNSSeedData("seed.testnetexplorer.digibyteservers.io", "seed.testnetexplorer.digibyteservers.io")
new DNSSeedData("testnetseed.digibyte.io", "testnetseed.digibyte.io"),
new DNSSeedData("testnetseed.digibyte.link", "testnetseed.digibyte.link"),
new DNSSeedData("testnetseed.digibyte.services", "testnetseed.digibyte.services")
]);

return builder;
Expand All @@ -86,7 +104,10 @@ protected override NetworkBuilder CreateRegtest()
SubsidyHalvingInterval = 150,
MajorityEnforceBlockUpgrade = 750,
MajorityRejectBlockOutdated = 950,
MajorityWindow = 1000
MajorityWindow = 1000,
SupportSegwit = true,
SupportTaproot = true,
PowTargetSpacing = System.TimeSpan.FromSeconds(15)
})
.SetBase58Bytes(Base58Type.PUBKEY_ADDRESS, [126])
.SetBase58Bytes(Base58Type.SCRIPT_ADDRESS, [140])
Expand All @@ -95,11 +116,13 @@ protected override NetworkBuilder CreateRegtest()
.SetBase58Bytes(Base58Type.EXT_SECRET_KEY, [0x04, 0x35, 0x83, 0x94])
.SetBech32(Bech32Type.WITNESS_PUBKEY_ADDRESS, Encoders.Bech32("dgbrt"))
.SetBech32(Bech32Type.WITNESS_SCRIPT_ADDRESS, Encoders.Bech32("dgbrt"))
.SetBech32(Bech32Type.TAPROOT_ADDRESS, Encoders.Bech32("dgbrt"))
.SetMagic(0xDAB5BFFA)
.SetPort(18444)
.SetRPCPort(18443)
.SetMaxP2PVersion(70017) // DigiByte Core MIN_PEER_PROTO_VERSION
.SetGenesis(
"01000000000000000000000000000000000000000000000000000000000000003ba3edfd7a7b12b27ac72c3e67768f617fc81bc3888a51323a9fb8aa4b1e5e4a29ab5f49ffff001d1dac2b7c0101000000010000000000000000000000000000000000000000000000000000000000000000ffffffff4d04ffff001d01045468652054696d65732030332f4a616e2f32303039204368616e63656c6f72206f6e206272696e6b206f66207365636f6e64206261696c6f757420666f722062616e6b73ffffffff010040b743ba000000434104678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38c4f35504e51ec112de5c384df7ba0b8d578a4c702b6bf11d5fac00000000");
"010000000000000000000000000000000000000000000000000000000000000000000000ad0f7d7518fc1e90ed28bd0e444ccd8e24d94688355705ed2142006b49d9dd723a22915affff7f20040000000101000000010000000000000000000000000000000000000000000000000000000000000000ffffffff4d04ffff001d01044555534120546f6461793a2031302f4a616e2f323031342c205461726765743a20446174612073746f6c656e2066726f6d20757020746f203131304d20637573746f6d657273ffffffff01401f0000000000000200ac00000000");

return builder;
}
Expand Down
47 changes: 47 additions & 0 deletions NBitcoin.Tests/AltcoinTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,5 +782,52 @@ public void GIVEN_Digibyte_WHEN_ProvidedAddressForSpecificNetwork_THEN_ShouldPar
Assert.NotNull(testnetAddressParsed);
Assert.NotNull(testnetAddressParsed.ScriptPubKey);
}

[Fact]
[Trait("UnitTest", "UnitTest")]
public void DigiByteHasCorrectGenesisBlocks()
{
// Hashes asserted in DigiByte Core v9.26 src/kernel/chainparams.cpp
Assert.Equal(uint256.Parse("7497ea1b465eb39f1c8f507bc877078fe016d6fcb6dfad3a64c98dcc6e1e8496"), AltNetworkSets.DigiByte.Mainnet.GenesisHash);
Assert.Equal(uint256.Parse("0c9af936f28f7bd0e90c8f6235399063a026ed267bb53da398313b5d7aa55d82"), AltNetworkSets.DigiByte.Testnet.GenesisHash);
Assert.Equal(uint256.Parse("4598a0f2b823aaf9e77ee6d5e46f1edb824191dcd48b08437b7cec17e6ae6e26"), AltNetworkSets.DigiByte.Regtest.GenesisHash);
foreach (var network in new[] { AltNetworkSets.DigiByte.Mainnet, AltNetworkSets.DigiByte.Testnet, AltNetworkSets.DigiByte.Regtest })
{
var genesis = network.GetGenesis();
Assert.Equal(genesis.Header.HashMerkleRoot, genesis.GetMerkleRoot().Hash);
}
}

[Fact]
[Trait("UnitTest", "UnitTest")]
public void DigiByteSupportsSegwitAndModernPeers()
{
var key = new Key();
foreach (var network in new[] { AltNetworkSets.DigiByte.Mainnet, AltNetworkSets.DigiByte.Testnet, AltNetworkSets.DigiByte.Regtest })
{
// DigiByte Core v8.22+ disconnects peers below protocol version 70017
Assert.True(network.MaxP2PVersion >= 70017);
Assert.True(network.Consensus.SupportSegwit);
Assert.True(network.Consensus.SupportTaproot);
// Used to convert durations to block counts (e.g. by NBXplorer when pruning)
Assert.Equal(TimeSpan.FromSeconds(15), network.Consensus.PowTargetSpacing);
}
Assert.StartsWith("dgb1q", key.PubKey.GetAddress(ScriptPubKeyType.Segwit, AltNetworkSets.DigiByte.Mainnet).ToString());
#if HAS_SPAN
Assert.StartsWith("dgb1p", key.PubKey.GetAddress(ScriptPubKeyType.TaprootBIP86, AltNetworkSets.DigiByte.Mainnet).ToString());
#endif
Assert.StartsWith("dgbrt1q", key.PubKey.GetAddress(ScriptPubKeyType.Segwit, AltNetworkSets.DigiByte.Regtest).ToString());
}

[Fact]
[Trait("UnitTest", "UnitTest")]
public void DigiByteHasDefaultCookiePaths()
{
if (Network.GetDefaultDataFolder("DigiByte") is not string folder)
return;
Assert.Equal(Path.Combine(folder, ".cookie"), RPC.RPCClient.TryGetDefaultCookieFilePath(AltNetworkSets.DigiByte.Mainnet));
Assert.Equal(Path.Combine(folder, "testnet26", ".cookie"), RPC.RPCClient.TryGetDefaultCookieFilePath(AltNetworkSets.DigiByte.Testnet));
Assert.Equal(Path.Combine(folder, "regtest", ".cookie"), RPC.RPCClient.TryGetDefaultCookieFilePath(AltNetworkSets.DigiByte.Regtest));
}
}
}
Loading