Repository navigation
Avoid transaction-wide work during PSBT input finalization - #1365
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid repeated whole-transaction work when finalizing PSBT inputs, particularly large unsigned or partially signed PSBTs that cannot be finalized.
TransactionBuilder.ExtractSignaturesAPI is unchanged.SignOnlyInputIndexis set, rather than enumerating every input and skipping the others. An out-of-range index continues to produce no input signing contexts. This also benefits single-input signing.These changes remove two sources of quadratic work without adding a cache to mutable PSBT objects or disabling
IsSmartglobally.This does not eliminate all transaction-wide work from repeated public
TryFinalizeInput()calls: callers should still precompute signing data once throughSettings.SigningOptions.PrecomputedTransactionData, or use bulkTryFinalize(), which already shares that data. A corresponding BTCPay Server caller adjustment is separate from this PR.The library builds successfully for all four target frameworks, and the existing test project compiles for both targets. Tests were not run locally.