Skip to content

Remove use of NO_NATIVE_BIGNUM - #1368

Merged
NicolasDorier merged 1 commit into
MetacoSA:masterfrom
Carti-it:remove-NO_NATIVE_BIGNUM
Oct 29, 2026
Merged

NicolasDorier merged 1 commit into
MetacoSA:masterfrom
Carti-it:remove-NO_NATIVE_BIGNUM

Conversation

@Carti-it

Copy link
Copy Markdown
Contributor

I found that it was introduced in #830. I don't think it's used anymore.

@NicolasDorier

Copy link
Copy Markdown
Collaborator

The end of an era

@NicolasDorier

Copy link
Copy Markdown
Collaborator

@Carti-it did you check where we coulnd't remove some stuff from BouncyCastle that we copied in the project as well then?

@Carti-it

Copy link
Copy Markdown
Contributor Author

@Carti-it did you check where we coulnd't remove some stuff from BouncyCastle that we copied in the project as well then?

If you mean NBitcoin.BouncyCastle.Math namespace here in NBitcoin and BigInteger.cs, it seems that it cannot be removed simply. It appears it's used when compiled for netstandard2.0 and net472.

@NicolasDorier
NicolasDorier merged commit b99802d into MetacoSA:master Oct 29, 2026
6 checks passed
@Carti-it
Carti-it deleted the remove-NO_NATIVE_BIGNUM branch October 29, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants