Skip to content

Optimize hash160 slightly #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicolasDorier merged 2 commits into from
Nov 1, 2026
Merged

Optimize hash160 slightly #1372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b5ae96
HashBench: Add a benchmark
Carti-it Nov 1, 2026
7ffbf81
Hashes: Optimize `Hash160`
Carti-it Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions NBitcoin.Bench/HashBench.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using BenchmarkDotNet.Attributes;
using NBitcoin.Crypto;
using NBitcoin.DataEncoders;
using System;

namespace NBitcoin.Bench;

Expand All @@ -15,6 +16,12 @@ public void Setup()
bytes = Encoders.Hex.DecodeData("d54994ece1d11b19785c7248868696250ab195605b469632b7bd68130e880c9a");
}

[Benchmark]
public void Hash160()
{
Hashes.Hash160(bytes.AsSpan());
}

[Benchmark]
public void SHA1()
{
Expand Down
15 changes: 12 additions & 3 deletions NBitcoin/Crypto/Hashes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ public static uint160 Hash160(byte[] data)
{
return Hash160(data, 0, data.Length);
}

#if HAS_SPAN
public static uint160 Hash160(ReadOnlySpan<byte> data)
{
// TODO: optimize
return Hash160(data.ToArray());
return new uint160(Hash160RawBytes(data));
}
#endif

Expand All @@ -63,8 +63,17 @@ public static uint160 Hash160(byte[] data, int offset, int count)
{
return new uint160(Hash160RawBytes(data, offset, count));
}

public static byte[] Hash160RawBytes(byte[] data)
=> Hash160RawBytes(data, 0, data.Length);
=> Hash160RawBytes(data, 0, data.Length);

#if HAS_SPAN
public static byte[] Hash160RawBytes(ReadOnlySpan<byte> data)
{
return RIPEMD160(SHA256(data));
}
#endif

public static byte[] Hash160RawBytes(byte[] data, int offset, int count)
{
return RIPEMD160(SHA256(data, offset, count));
Expand Down
Loading