Conversation
huppd
reviewed
Feb 16, 2026
Collaborator
huppd
left a comment
huppd
left a comment
There was a problem hiding this comment.
Thanks, this is a greate improvement, it makes using it much clearer and makes it more robust. I commited some changes in the test to be sure that now the tool covers more date formats. I only have some minor suggestions.
| rstcheck = ">=6.2.4" | ||
|
|
||
| # Testing tools: pytest & coverage | ||
| types-python-dateutil = "^2.9.0.20260124" |
Collaborator
There was a problem hiding this comment.
I think it would be better to have this moved up to the non-development requirements. Also wouldn't it be enough to add python-dateutil? I probably would also just prescribe ^2.9.0, but I guess this is a matter of taste.
| TIMING_START_REGEX = r"\s+L?\s*[a-zA-Z_.]+" | ||
| TIMING_ELEMENT_REGEX = r"(?:\[?\d+[.msh]?\d*s?\]? +)" | ||
| TIMING_REGEX = TIMING_START_REGEX + " +" + TIMING_ELEMENT_REGEX + "{6,20} *(?!.)" | ||
| LOG_FILE = TIMING_START_REGEX + r"\s+(?:" + TIMING_ELEMENT_REGEX + r"){6,20} *(?!.)" |
Collaborator
There was a problem hiding this comment.
This is actuall a timing reges, I think here it is OK to keep the previous name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses all improvements mentioned in issue #91 :