Skip to content

Release/2.0 - #45

Open
jankapunkt wants to merge 13 commits into
masterfrom
release/2.0
Open

Release/2.0#45
jankapunkt wants to merge 13 commits into
masterfrom
release/2.0

Conversation

@jankapunkt

Copy link
Copy Markdown
Member

This acknowledges #43, updated the tests for full async compat and fixed minor regressions, revealed after tests were running again.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the meteor-publication-collector package to version 2.0, providing full compatibility with Meteor 3.0. The update modernizes the codebase by removing dependency on underscore, implementing full async/await support, and updating the package name to reflect community maintenance.

Key changes include:

  • Migration to Meteor 3.0 with async collection methods and modern JavaScript patterns
  • Complete removal of underscore dependency in favor of native JavaScript
  • Full async/await support throughout the codebase and tests

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
publication-collector.js Core logic updated with async handling, underscore removal, and modern JavaScript patterns
publication-collector.test.js Test suite converted to async/await with updated collection method calls
tests/publications.js Publication definitions updated to use async functions and modern collection methods
tests/helpers.js New async test utilities added for error handling and iteration
tests/collections.js Collection exports updated to use ES6 export syntax
package.js Package configuration updated for Meteor 3.0 and community maintenance
README.md Documentation updated with new package name and async examples
.versions Dependency versions updated to reflect Meteor 3.0 compatibility
Files not reviewed (1)
  • .npm/package/npm-shrinkwrap.json: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread tests/helpers.js Outdated
Comment thread publication-collector.js Outdated
Comment thread publication-collector.js Outdated
Comment thread publication-collector.js Fixed
Comment thread publication-collector.js Fixed
Comment thread publication-collector.js Fixed
Comment thread publication-collector.js Fixed
jankapunkt and others added 6 commits April 10, 2026 09:53
… assignment

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
… assignment

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@jankapunkt

jankapunkt commented Apr 10, 2026

Copy link
Copy Markdown
Member Author

@StorytellerCZ published 2.0.0-rc.2 and added CI this should be ready to merge now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants