Release/2.0 - #45
Open
jankapunkt wants to merge 13 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the meteor-publication-collector package to version 2.0, providing full compatibility with Meteor 3.0. The update modernizes the codebase by removing dependency on underscore, implementing full async/await support, and updating the package name to reflect community maintenance.
Key changes include:
- Migration to Meteor 3.0 with async collection methods and modern JavaScript patterns
- Complete removal of underscore dependency in favor of native JavaScript
- Full async/await support throughout the codebase and tests
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| publication-collector.js | Core logic updated with async handling, underscore removal, and modern JavaScript patterns |
| publication-collector.test.js | Test suite converted to async/await with updated collection method calls |
| tests/publications.js | Publication definitions updated to use async functions and modern collection methods |
| tests/helpers.js | New async test utilities added for error handling and iteration |
| tests/collections.js | Collection exports updated to use ES6 export syntax |
| package.js | Package configuration updated for Meteor 3.0 and community maintenance |
| README.md | Documentation updated with new package name and async examples |
| .versions | Dependency versions updated to reflect Meteor 3.0 compatibility |
Files not reviewed (1)
- .npm/package/npm-shrinkwrap.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
… assignment Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
… assignment Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…teor-publication-collector into release/2.0
Member
Author
|
@StorytellerCZ published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This acknowledges #43, updated the tests for full async compat and fixed minor regressions, revealed after tests were running again.