Maintenance - upgrade Meteor to 3.4 in testapp#440
Maintenance - upgrade Meteor to 3.4 in testapp#440jankapunkt wants to merge 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the testapp3 Meteor test application to Meteor 3.4, refreshes related npm dev dependencies, and updates CI to run against newer Node/Meteor versions.
Changes:
- Bump
testapp3Meteor release toMETEOR@3.4and update.meteor/packages/.meteor/versionsaccordingly. - Update
testapp3npm dependencies/devDependencies (Babel runtime, nyc, chai, puppeteer, etc.). - Update GitHub Actions workflow to use Node 22 and add Meteor
3.4to the test matrix.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
testapp3/package.json |
Updates npm dependency versions used by the Meteor 3 test app. |
testapp3/.meteor/versions |
Refreshes Meteor package versions for the Meteor 3.4 upgrade. |
testapp3/.meteor/release |
Pins the test app to METEOR@3.4. |
testapp3/.meteor/packages |
Updates pinned Meteor package versions (e.g., mongo, static-html, minifiers, typescript). |
.github/workflows/testsuite.yml |
Moves CI to Node 22 and expands Meteor 3 testing to include 3.4. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| matrix: | ||
| meteorRelease: | ||
| - '3.0.2' | ||
| - '3.4' | ||
| steps: |
There was a problem hiding this comment.
The meteorRelease matrix likely won’t actually control which Meteor version runs because the app is pinned to METEOR@3.4 in testapp3/.meteor/release and the meteor test-packages command isn’t passed --release ${{ matrix.meteorRelease }} (or equivalent). This can cause the 3.0.2 matrix entry to still run Meteor 3.4 (or fail due to release mismatch), reducing the value of the matrix. Consider invoking meteor --release ${{ matrix.meteorRelease }} test-packages ... or rewriting testapp3/.meteor/release per matrix entry before running tests.
Upgrades npm deps, ci and Meteor to 3.4