Skip to content

Maintenance - upgrade Meteor to 3.4 in testapp#440

Open
jankapunkt wants to merge 2 commits intomasterfrom
deps/meteor-3.4
Open

Maintenance - upgrade Meteor to 3.4 in testapp#440
jankapunkt wants to merge 2 commits intomasterfrom
deps/meteor-3.4

Conversation

@jankapunkt
Copy link
Copy Markdown
Member

Upgrades npm deps, ci and Meteor to 3.4

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the testapp3 Meteor test application to Meteor 3.4, refreshes related npm dev dependencies, and updates CI to run against newer Node/Meteor versions.

Changes:

  • Bump testapp3 Meteor release to METEOR@3.4 and update .meteor/packages / .meteor/versions accordingly.
  • Update testapp3 npm dependencies/devDependencies (Babel runtime, nyc, chai, puppeteer, etc.).
  • Update GitHub Actions workflow to use Node 22 and add Meteor 3.4 to the test matrix.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
testapp3/package.json Updates npm dependency versions used by the Meteor 3 test app.
testapp3/.meteor/versions Refreshes Meteor package versions for the Meteor 3.4 upgrade.
testapp3/.meteor/release Pins the test app to METEOR@3.4.
testapp3/.meteor/packages Updates pinned Meteor package versions (e.g., mongo, static-html, minifiers, typescript).
.github/workflows/testsuite.yml Moves CI to Node 22 and expands Meteor 3 testing to include 3.4.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 69 to 73
matrix:
meteorRelease:
- '3.0.2'
- '3.4'
steps:
Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The meteorRelease matrix likely won’t actually control which Meteor version runs because the app is pinned to METEOR@3.4 in testapp3/.meteor/release and the meteor test-packages command isn’t passed --release ${{ matrix.meteorRelease }} (or equivalent). This can cause the 3.0.2 matrix entry to still run Meteor 3.4 (or fail due to release mismatch), reducing the value of the matrix. Consider invoking meteor --release ${{ matrix.meteorRelease }} test-packages ... or rewriting testapp3/.meteor/release per matrix entry before running tests.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants