Skip to content

perf: switch wildcard dedup to O(1) set-based approach #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NassimBtk merged 3 commits into from
Mar 20, 2026
Merged

perf: switch wildcard dedup to O(1) set-based approach #50

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6440dd1
Initial plan
Copilot Mar 19, 2026
ff7d5ae
Switch wildcard dedup to set-based approach for O(1) case-insensitive…
Copilot Mar 19, 2026
a4a6b02
Merge branch 'feature/issue-48-support-iterating-over-object-children…
NassimBtk Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions src/main/java/org/metricshub/jflat/JFlat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@
import java.io.StringReader;
import java.text.ParseException;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.Map.Entry;
import java.util.Set;
import java.util.TreeMap;
import javax.json.Json;
import javax.json.JsonArray;
Expand Down Expand Up @@ -399,6 +401,8 @@ public StringBuilder toCSV(String csvEntryKey, String[] csvProperties, String se

// Temporary list where we will store the new entries
ArrayList<String> newEntries = new ArrayList<String>();
// Set of lower-cased paths already added, used for O(1) case-insensitive dedup
Set<String> seenLowercasePaths = new HashSet<String>();

for (String existingEntry : entries) {
if (isWildcard) {
Expand Down Expand Up @@ -436,18 +440,10 @@ public StringBuilder toCSV(String csvEntryKey, String[] csvProperties, String se
childName = remainder.substring(0, Math.min(slashPos, bracketPos));
}

// Add the child path if it's valid and not already in the list
// Add the child path if it's valid and not already seen (case-insensitive)
if (!childName.isEmpty()) {
String childPath = prefix + childName;
// Deduplicate (case-insensitive, consistent with the TreeMap)
boolean alreadyAdded = false;
for (String added : newEntries) {
if (added.equalsIgnoreCase(childPath)) {
alreadyAdded = true;
break;
}
}
if (!alreadyAdded) {
if (seenLowercasePaths.add(childPath.toLowerCase())) {
newEntries.add(childPath);
}
}
Expand Down