Use tailMap for O(matches) wildcard key iteration instead of O(totalKeys)#52
Merged
NassimBtk merged 3 commits intofeature/issue-48-support-iterating-over-object-children-using-wildcardfrom Mar 20, 2026
Conversation
…eys) Co-authored-by: NassimBtk <14110109+NassimBtk@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on wildcard iteration performance improvement
Use tailMap for O(matches) wildcard key iteration instead of O(totalKeys)
Mar 20, 2026
NassimBtk
approved these changes
Mar 20, 2026
…-using-wildcard' into copilot/sub-pr-49
172ee43
into
feature/issue-48-support-iterating-over-object-children-using-wildcard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wildcard expansion was scanning the entire
map.keySet()for everyexistingEntry, making each lookup O(totalKeys) regardless of how many keys actually matched.Changes
tailMap-bounded iteration: Replacemap.keySet()withmap.tailMap(prefix, true).keySet()so the scan starts at the first key that could match the prefix rather than at the beginning of the map.regionMatchescheck), avoiding traversal of unrelated keys.Because the
TreeMapusesString.CASE_INSENSITIVE_ORDER,tailMapuses the same comparator — all case variants of a given prefix are grouped consecutively, so the break is safe and no matches are skipped.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.