Skip to content

Fix locale-sensitive toLowerCase() in wildcard path dedup#53

Merged
NassimBtk merged 2 commits intofeature/issue-48-support-iterating-over-object-children-using-wildcardfrom
copilot/sub-pr-49-again
Mar 20, 2026
Merged

Fix locale-sensitive toLowerCase() in wildcard path dedup#53
NassimBtk merged 2 commits intofeature/issue-48-support-iterating-over-object-children-using-wildcardfrom
copilot/sub-pr-49-again

Conversation

Copy link

Copilot AI commented Mar 20, 2026

childPath.toLowerCase() uses the default JVM locale, causing incorrect case folding in locales like Turkish (where Iı), leading to incorrect deduplication of wildcard child paths.

Changes

  • JFlat.java: Replace childPath.toLowerCase() with childPath.toLowerCase(Locale.ROOT) for locale-independent case folding
  • Add import java.util.Locale

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Co-authored-by: NassimBtk <14110109+NassimBtk@users.noreply.github.com>
Copy link
Author

Copilot AI commented Mar 20, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • checkstyle.org
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/tools/linux64/java/bin/java /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/xml/tools/xml-extractor.jar --fileList=/tmp/codeql-scratch-3f672d5de33c41b7/dbs/java/working/files-to-index15355685787754852219.list --sourceArchiveDir=/tmp/codeql-scratch-3f672d5de33c41b7/dbs/java/src --outputDir=/tmp/codeql-scratch-3f672d5de33c41b7/dbs/java/trap/java (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] [WIP] Address feedback on wildcard iterations support in PR #48 Fix locale-sensitive toLowerCase() in wildcard path dedup Mar 20, 2026
Copilot AI requested a review from NassimBtk March 20, 2026 11:10
@NassimBtk NassimBtk marked this pull request as ready for review March 20, 2026 11:11
@NassimBtk NassimBtk merged commit d970dd6 into feature/issue-48-support-iterating-over-object-children-using-wildcard Mar 20, 2026
@NassimBtk NassimBtk deleted the copilot/sub-pr-49-again branch March 20, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants