Skip to content

Restore non-wildcard /arrayB/id test assertion for backward compatibility#54

Draft
Copilot wants to merge 2 commits intofeature/issue-48-support-iterating-over-object-children-using-wildcardfrom
copilot/sub-pr-49
Draft

Restore non-wildcard /arrayB/id test assertion for backward compatibility#54
Copilot wants to merge 2 commits intofeature/issue-48-support-iterating-over-object-children-using-wildcardfrom
copilot/sub-pr-49

Conversation

Copy link

Copilot AI commented Mar 20, 2026

The switch from /arrayB/id to /arrayB/*/id in the csvSimple test left the original non-wildcard array traversal path untested, removing regression coverage for existing behavior.

Changes

  • JFlatTest.java: Re-adds the /arrayB/id assertion alongside the new /arrayB/*/id wildcard assertion, so both paths are explicitly verified to produce identical results:
// Non-wildcard (backward compatibility)
assertEquals(
    "[0]/arrayB[0]/id;\n...[1]/arrayB[2]/id;\n",
    simple.toCSV("/arrayB/id", null, null).toString()
);
// Wildcard (new feature)
assertEquals(
    "[0]/arrayB[0]/id;\n...[1]/arrayB[2]/id;\n",
    simple.toCSV("/arrayB/*/id", null, null).toString()
);

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

… for backward compatibility

Co-authored-by: NassimBtk <14110109+NassimBtk@users.noreply.github.com>
Agent-Logs-Url: https://github.com/MetricsHub/jflat/sessions/eef4dd5d-c09f-4518-a4d2-2b7e8d215c41
Copy link
Author

Copilot AI commented Mar 20, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • checkstyle.org
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/tools/linux64/java/bin/java /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/xml/tools/xml-extractor.jar --fileList=/tmp/codeql-scratch-3f672d5de33c41b7/dbs/java/working/files-to-index3924113648345410112.list --sourceArchiveDir=/tmp/codeql-scratch-3f672d5de33c41b7/dbs/java/src --outputDir=/tmp/codeql-scratch-3f672d5de33c41b7/dbs/java/trap/java (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] [WIP] Address feedback on wildcard iterations support in PR #48 Restore non-wildcard /arrayB/id test assertion for backward compatibility Mar 20, 2026
Copilot AI requested a review from NassimBtk March 20, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants