Skip to content

Merge branch 'main' into dependabot/maven/org.junit-junit-bom-6.0.0

0ce57de
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Bump org.junit:junit-bom from 5.12.1 to 6.0.0 #48

Merge branch 'main' into dependabot/maven/org.junit-junit-bom-6.0.0
0ce57de
Select commit
Loading
Failed to load commit list.
GitHub Actions / spotbugs completed Oct 14, 2025 in 0s

SpotBugs Source Code Analyzer report

1 violation(s) found

Annotations

Check warning on line 178 in src/main/java/org/metricshub/vcenter/VCenterClient.java

See this annotation in the file changed.

@github-actions github-actions / spotbugs

SBSC_USE_STRINGBUFFER_CONCATENATION

org.metricshub.vcenter.VCenterClient.getHostSystemManagedEntity(ServiceInstance, String) concatenates strings using + in a loop
Raw output
 The method seems to be building a String using concatenation in a loop. In each iteration, the String is converted to a StringBuffer/StringBuilder, appended to, and converted back to a String. This can lead to a cost quadratic in the number of iterations, as the growing string is recopied in each iteration. 

Better performance can be obtained by using a StringBuffer (or StringBuilder in Java 5) explicitly.

 For example:

// This is bad
String s = "";
for (int i = 0; i < field.length; ++i) {
    s = s + field[i];
}

// This is better
StringBuffer buf = new StringBuffer();
for (int i = 0; i < field.length; ++i) {
    buf.append(field[i]);
}
String s = buf.toString();