fix(dex): escrow trading competition rewards before they can be claimed - #1077
Merged
nanaf6203-bit merged 1 commit intoAug 29, 2026
Conversation
create_trading_competition is now payable and requires the reward to be funded up front: the attached value is escrowed in competition_reward_escrow and the governance supply is minted once, by exactly the escrowed amount. claim_competition_reward pays winners pro rata from the escrow and no longer inflates total_supply, so an unfunded competition yields RewardUnavailable and supply grows only by value actually held for the competition. Closes MettaChain#1022
|
@jonathanayubausara-a11y Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
nanaf6203-bit
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1022.
claim_competition_rewardpreviously minted governance tokens from nothing:governance_balancesandtotal_supplywere credited by the competition'sreward_amountwith no value ever escrowed (the DEX had no payable messages and notransferred_valuereads).This PR makes the reward pool custody-backed:
create_trading_competitionis nowpayable. The caller must attach native value at least equal toreward_amount; an unfunded competition is rejected.competition_reward_escrowmapping, and the governancetotal_supplyis minted once, by exactly the escrowed amount.claim_competition_rewardpays winners pro rata from the escrow (min(reward_amount * score / total_score, remaining escrow)), deducts the payout, and no longer touchestotal_supply. An unfunded/fully-drawn competition yieldsRewardUnavailable.get_competition_reward_escrowmessage exposes the remaining escrow.Verification
cargo test -p propchain-dex— 30 passed, including a full lifecycle test asserting supply increases only by the escrowed amount and the escrow shrinks by exactly the claimcargo clippy -p propchain-dex --all-targets -- -D warnings— cleancargo check --workspace— cleanCloses #1022