Fix a bunch of bugs (#1780)

Author: MewPurPur

src/ui_parts/main_canvas.gd

@@ -36,7 +36,7 @@ func sync_camera_zoom_in_tab() -> void:
 func sync_svg_size() -> void:
 	if _current_svg_width != root_element.width or _current_svg_height != root_element.height:
 		_current_svg_width = root_element.width
-		_current_svg_width = root_element.height
+		_current_svg_height = root_element.height
 		sync_checkerboard()
 		center_frame()
 		queue_redraw()

src/ui_widgets/Canvas.gd

@@ -107,6 +107,7 @@ func _enter_tree() -> void:
 	checkerboard.expand_mode = TextureRect.EXPAND_IGNORE_SIZE
 	checkerboard.stretch_mode = TextureRect.STRETCH_TILE
 	checkerboard.texture_filter = TEXTURE_FILTER_NEAREST
+	checkerboard.clip_contents = true
 	var zoom_shader_material := ShaderMaterial.new()
 	zoom_shader_material.shader = preload("res://src/shaders/zoom_shader.gdshader")
 	checkerboard.material = zoom_shader_material
@@ -188,7 +189,7 @@ func _texture_update() -> void:
 	var image_zoom := 1.0 if view_rasterized and camera_zoom > 1.0 else camera_zoom
 	var pixel_size := 1 / image_zoom
 
-	# Translate to canvas coords.
+	# Expand by pixel_size * 2 so external colors can affect it.
 	var display_rect := texture_view_rect.grow(pixel_size * 2)
 	display_rect.position = display_rect.position.snapped(Vector2(pixel_size, pixel_size)).maxf(0.0)
 	display_rect.size = display_rect.size.snapped(Vector2(pixel_size, pixel_size))
@@ -199,14 +200,14 @@ func _texture_update() -> void:
 	if cached_inner_markup.is_empty():
 		cached_inner_markup = SVGParser.get_inner_markup_with_percentages_converted(root_element)
 
+	# Translate to canvas coords.
 	var svg_text := SVGParser.root_cutout_to_markup(root_element, display_rect.size,
 			Rect2(root_element.world_to_canvas(display_rect.position),
 			display_rect.size / root_element.canvas_transform.get_scale()), cached_inner_markup)
 
 	# TODO Necessary workaround to Godot ignoring position changes below a treshold.
 	display_texture.position = Vector2(NAN, NAN)
 	display_texture.position = display_rect.position
-	
 	display_texture.size = display_rect.size
 	display_texture.texture = DPITexture.create_from_string(svg_text, image_zoom)
 
@@ -307,8 +308,11 @@ func set_zoom(new_zoom: float, offset := Vector2(0.5, 0.5)) -> void:
 
 # Top left corner.
 func set_view(new_center: Vector2) -> void:
-	camera_center = new_center.clamp(limit_top_left, limit_bottom_right)
+	new_center = new_center.clamp(limit_top_left, limit_bottom_right)
+	if new_center == camera_center:
+		return
 
+	camera_center = new_center
 	var stripped_left := maxf(camera_center.x - size.x / camera_zoom / 2.0, 0.0)
 	var stripped_top := maxf(camera_center.y - size.y / camera_zoom / 2.0, 0.0)
 	var stripped_right := minf(camera_center.x + size.x / camera_zoom / 2.0, root_element.width)

src/ui_widgets/file_path_field.gd src/ui_widgets/file_path_edit.gdsrc/ui_widgets/file_path_field.gd renamed to src/ui_widgets/file_path_edit.gd

@@ -1,6 +1,6 @@
 [gd_scene format=3 uid="uid://dm3l2yb8crdqr"]
 
-[ext_resource type="Script" uid="uid://dm646g7ndq56u" path="res://src/ui_widgets/file_path_field.gd" id="1_vugfe"]
+[ext_resource type="Script" uid="uid://dm646g7ndq56u" path="res://src/ui_widgets/file_path_edit.gd" id="1_vugfe"]
 [ext_resource type="Script" uid="uid://1hox6gd5pxku" path="res://src/ui_widgets/BetterLineEdit.gd" id="2_vugfe"]
 [ext_resource type="Texture2D" uid="uid://n6ive1o6t4bp" path="res://assets/icons/FileBrowse.svg" id="3_qlle3"]
 

src/ui_widgets/file_path_field.gd.uid src/ui_widgets/file_path_edit.gd.uidsrc/ui_widgets/file_path_field.gd.uid renamed to src/ui_widgets/file_path_edit.gd.uid

@@ -10,7 +10,7 @@ const OptimizerSettingInfoScene = preload("res://src/ui_widgets/optimizer_settin
 const ColorEditScene = preload("res://src/ui_widgets/color_edit.tscn")
 const BasicDropdownScene = preload("res://src/ui_widgets/dropdown_basic.tscn")
 const NumericDropdownScene = preload("res://src/ui_widgets/dropdown_numeric.tscn")
-const FilePathFieldScene = preload("res://src/ui_widgets/file_path_field.tscn")
+const FilePathFieldScene = preload("res://src/ui_widgets/file_path_edit.tscn")
 
 const reload_icon = preload("res://assets/icons/Reload.svg")
 const clear_icon = preload("res://assets/icons/Clear.svg")

src/ui_widgets/file_path_field.tscn src/ui_widgets/file_path_edit.tscnsrc/ui_widgets/file_path_field.tscn renamed to src/ui_widgets/file_path_edit.tscn

@@ -475,13 +475,13 @@ func setup_theming_content() -> void:
 
 	add_section(Translator.translate("Fonts"))
 	current_setup_setting = "main_font_path"
-	add_font_file_path_field(Translator.translate("Main font"))
+	add_font_file_path_edit(Translator.translate("Main font"))
 	add_preview(SettingFontPreview.new(ThemeUtils.main_font))
 	current_setup_setting = "bold_font_path"
-	add_font_file_path_field(Translator.translate("Bold font"))
+	add_font_file_path_edit(Translator.translate("Bold font"))
 	add_preview(SettingFontPreview.new(ThemeUtils.bold_font))
 	current_setup_setting = "mono_font_path"
-	add_font_file_path_field(Translator.translate("Mono font"))
+	add_font_file_path_edit(Translator.translate("Mono font"))
 	add_preview(SettingFontPreview.new(ThemeUtils.mono_font))
 
 	add_section(Translator.translate("SVG Text colors"))
@@ -815,10 +815,10 @@ func add_color_edit(text: String, alpha_enabled := true) -> Control:
 	current_setup_container.add_child(frame)
 	return frame
 
-func add_font_file_path_field(text: String) -> Control:
-	return _add_file_path_field(text, Utils.DYNAMIC_FONT_FORMATS)
+func add_font_file_path_edit(text: String) -> Control:
+	return _add_file_path_edit(text, Utils.DYNAMIC_FONT_FORMATS)
 
-func _add_file_path_field(text: String, extensions_list: PackedStringArray) -> Control:
+func _add_file_path_edit(text: String, extensions_list: PackedStringArray) -> Control:
 	var frame := SettingFrameScene.instantiate()
 	frame.text = text
 	setup_frame(frame)

src/ui_widgets/setting_frame.gd

@@ -255,7 +255,7 @@ static func recalculate_colors() -> void:
 	shadow_color = Color(0, 0, 0, 0.1 if ThemeUtils.is_theme_dark else 0.08)
 
 static func rebuild_fonts() -> void:
-	# FIXME emitting changed seems to be necessitated only by a Godot bug: #122082.
+	# FIXME emitting changed seems to be necessary only due to Godot bug #122082.
 	main_font.base_font = FontFile.new()
 	if not Configs.savedata.main_font_path.is_empty():
 		main_font.base_font.load_dynamic_font(Configs.savedata.main_font_path)

src/ui_widgets/settings_content_generic.gd

@@ -89,7 +89,7 @@ static func get_action_description(action_name: String, for_button := false) ->
 		_: return action_name
 
 ## Returns a translated description for an SVG path command character.
-## If omit_relativity is true, doesn't append "(Relative)"/"(Absolute)" suffix.
+## If show_relativity is true, append "(Relative)"/"(Absolute)" suffix.
 static func get_path_command_description(command_char: String, show_relativity := false) -> String:
 	var description: String
 	match command_char:
@@ -107,10 +107,8 @@ static func get_path_command_description(command_char: String, show_relativity :
 
 	if not show_relativity:
 		return description
-	elif Utils.is_string_lower(command_char):
-		return description + " (" + Translator.translate("Relative") + ")"
-	else:
-		return description + " (" + Translator.translate("Absolute") + ")"
+	return "%s (%s)" % [description, Translator.translate("Relative") if\
+			Utils.is_string_lower(command_char) else Translator.translate("Absolute")]
 
 ## Returns the translated name for a layout part.
 static func get_layout_part_name(layout_part: Utils.LayoutPart) -> String:

src/utils/ThemeUtils.gd

@@ -69,7 +69,7 @@ static func rotate_flat_stylebox_90_left(stylebox: StyleBoxFlat) -> void:
 	stylebox.corner_radius_top_right = stylebox.corner_radius_bottom_right
 	stylebox.corner_radius_bottom_right = temp2
 
-	var temp3 := stylebox.border_width_left
+	var temp3 := stylebox.content_margin_left
 	stylebox.content_margin_left = stylebox.content_margin_top
 	stylebox.content_margin_top = stylebox.content_margin_right
 	stylebox.content_margin_right = stylebox.content_margin_bottom