Pebble Draw Command preview and export by sockeye-d · Pull Request #1587 · MewPurPur/GodSVG

sockeye-d · 2026-01-28T05:26:51Z

The Pebble Draw Command (PDC) format is a vector format used by the Pebble smartwatches to draw scalable graphics. This PR adds export support for it, as well as extending the preview panel to look similar what the images would like like on real hardware. This includes quantization to 64 colors and snapping vertices to 1 or 1/16th pixels, depending on the precision mode.

The implementation was based on svg2pdc.

More information: https://developer.rebble.io/tutorials/advanced/vector-animations/#drawing-a-pdc-image, https://developer.rebble.io/guides/app-resources/pdc-format/

MewPurPur · 2026-02-08T21:45:59Z

The StreamPeer and StreamPeerBuffer classes are currently disabled in .github/disabled_classes.gdbuild as this PR is the first time they are used in the codebase. They need to be enabled for the artifacts to build correctly.

sockeye-d · 2026-02-08T22:35:41Z

It should be possible for me to make it use the PackedByteArray buffer directly without StreamPeer, I just prefer the API of StreamPeer. Would that be a better solution?

MewPurPur · 2026-02-08T23:15:16Z

Whatever you prefer.

sockeye-d · 2026-02-09T07:34:47Z

Should all be fixed now

MewPurPur · 2026-02-09T21:36:33Z

Either still hide the size of the file for png, jpeg, and webp, or implement it for these formats too.

I have a feeling the tessellation option doesn't work, I changed it and it didn't seem to affect the image or file size in the UI.

One of my SVGs is previewed like this:

Are artifacts like these intentional?

Are the two new SVGs needed? I don't know what those could be used for, and they seem to be unused at the moment.

MewPurPur · 2026-02-09T21:47:27Z

I'm against adding PDC-specific things in previews in this PR. We can do it later, but I think we should first investigate the idea of having utilities to preview every format, and to configure the previews just like in the image export menu.

sockeye-d · 2026-02-18T09:34:41Z

Right, should all be fixed now

MewPurPur · 2026-02-19T14:59:06Z

Could you rebase? I made some changes to the CI that make it so changing the disabled_classes file should result in new cache.

Edit: Nevermind, the CI needs more work

MewPurPur · 2026-02-21T02:44:14Z

The issues have been fixed, seems like they might have been from Godot 4.6.1. Could you rebase now?

sockeye-d · 2026-02-22T02:20:59Z

Rebased!

MewPurPur · 2026-02-22T08:02:14Z

It seems like transforms aren't accounted for, is this intentional?

MewPurPur · 2026-02-22T08:17:36Z

Other notes:

The size label is pretty nice, let's keep it for all formats! But tune down the export menu's VBoxes' spacings slightly, as webp is now so tall it shifts the layout
Add the new fields to the focus sequence in _ready()
The correct spelling is "tessellation" / "tessellate"
Align the precision dropdown right next to the "Precise:" label

MewPurPur · 2026-02-25T05:13:42Z

I actually realized the reason why the other formats have no size indication - there's no way to get one without converting the image, and there's no way to convert the image without a lag spike. Previews are limited to 512x512 for this reason. So it would either need to be reverted to how it was, or have some kind of indication that it's not the real deal for bigger images - I can't think of a good one.

The two SVGs in the PR seem cool, but are now unused if I'm not mistaken? If they are still necessary, import them as DPITexture.

sockeye-d · 2026-02-25T05:16:52Z

I could estimate the size of the image with the actual resolution by extrapolating the
clamped image's bytes per pixel to the full image's number of pixels, probably. Then I could add an " (estimated)" suffix when that happens.

The two SVGs are unused, but they were for the PDC preview checkbox in the previews panel — if we plan on bringing that back, I'll still need them.

MewPurPur · 2026-02-25T07:37:55Z

Hmm, okay, I have a different idea, but let's still keep them until then, just reimport both as DPITexture.

As for size estimation, I think that's a good idea!

sockeye-d · 2026-02-25T09:52:22Z

All fixed now. Would there be any interest in generating the export on a separate thread, then showing a throbber or something while it loads? That would sort of fix the slowness issue

MewPurPur · 2026-02-25T10:40:56Z

I tried that, but I needed a separate threadless solution for web and the complexity didn't feel worth it.

Will test in a bit in my lunch break.

MewPurPur · 2026-02-25T12:46:32Z

One more rebase, please? I broke context popups right as you were rebasing :(

…d PDC filepath, the preview is generated by parsing the PDC buffer so it should be extra accurate, more quality controls

…pses, add estimated file size

sockeye-d · 2026-02-26T07:29:07Z

Rebased on top of upstream/main

MewPurPur · 2026-03-03T08:30:15Z

Rectangles are broken and the "Precise:" section should be left-aligned. I'll go over the code in a bit.

MewPurPur

Other notes: The ThemeUtils changes should be reverted. They aren't utilized yet and they seem very hacky.

Edit: Also, maybe pull the whole export size estimation inside an if else block after checking if the format is SVG? Right now you have a bug where big SVGs will trigger the "approximate" label, and also have this weird match setup.

MewPurPur · 2026-03-03T08:31:43Z

+	var focus_sequence: Array[Control]
+	focus_sequence.append(clipboard_button)
+	focus_sequence.append(format_dropdown)
+	focus_sequence.append(path_quality_edit)
+	focus_sequence.append(precise_path_mode_dropdown)
+	focus_sequence.append(lossless_checkbox)
+	focus_sequence.append(quality_edit)
+	focus_sequence.append(scale_edit)
+	focus_sequence.append(width_edit)
+	focus_sequence.append(height_edit)
+	focus_sequence.append(cancel_button)
+	focus_sequence.append(export_button)
+
+	HandlerGUI.register_focus_sequence(self, focus_sequence, true)
+	clipboard_button.grab_focus(true)


I prefer that this doesn't get changed.

MewPurPur · 2026-03-03T08:35:01Z

 func update() -> void:
 	# Determine which fields are visible.
 	quality_related_container.visible = export_data.format in ["jpg", "jpeg", "webp"]
+	path_quality_container.visible = export_data.format in ["pdc"]


Suggested change

path_quality_container.visible = export_data.format in ["pdc"]

path_quality_container.visible = (export_data.format == "pdc")

MewPurPur · 2026-03-03T09:07:03Z

+			export_size = roundi(texture_preview.last_image_size * maxf(1.0, export_size_fac))
+	final_size_label.text = Translator.translate("Size") + ": " + String.humanize_size(export_size)
+	if export_size_fac > 1.0:
+		final_size_label.text += Translator.translate(" (approximate)")


Based on current conventions, only the "approximate" string should be translated and not the surrounding punctuation

MewPurPur · 2026-03-03T10:03:43Z


 window/size/viewport_width=1040
 window/size/viewport_height=650
-window/size/mode=2


What's this about?

MewPurPur · 2026-03-03T10:06:23Z

+static func generate_ellipse(
+	start: Vector2, end: Vector2, r: Vector2,
+	rot: float,
+	large_arc_flag: bool, sweep_flag: bool,
+	path_generator: PathGenerator = default_path_generator
+) -> PackedVector2Array:


Do the params in a single line like the rest of the codebase, also rename to generate_elliptical_arc.

MewPurPur · 2026-03-03T10:18:06Z

+	size = Vector2i(
+		sp.get_16(),
+		sp.get_16(),
+	)


Do on one line.

MewPurPur · 2026-03-03T10:19:18Z

+## [br][br]
+## Implementation based on the specification at [url]https://developer.rebble.io/guides/app-resources/pdc-format/[/url] and
+## [url=https://github.com/pebble-examples/cards-example/blob/master/tools/svg2pdc.py]svg2pdc.py[/url].
+class_name PDCImage


Is it meant to extend RefCounted (as by default)? If so, I think this should be explicit.

MewPurPur · 2026-03-03T10:22:44Z

+		var x := sp.get_16()
+		var y := sp.get_16()
+		center = Vector2(x, y)


I'd say no need for intermediate variables.

MewPurPur · 2026-03-03T10:23:20Z

+			var x := float(sp.get_16()) / (1 << 3)
+			var y := float(sp.get_16()) / (1 << 3)
+			points.append(Vector2(x, y))


I'd say no need for intermediate variables. Divide the whole thing by (1 << 3).

MewPurPur · 2026-03-03T10:23:50Z

+			var x := sp.get_16()
+			var y := sp.get_16()
+			points.append(Vector2(x, y))


I'd say no need for intermediate variables.

MewPurPur · 2026-03-03T11:39:32Z

I also found that curves no longer have tangents to their control points.

MewPurPur · 2026-04-23T10:28:59Z

The export menu was reworked, which requires significant changes for the PR. But it should overall fit into the new systems way better than it did with the old ones.

sockeye-d force-pushed the pbw-export branch from cecc675 to b807c5c Compare February 6, 2026 06:29

sockeye-d force-pushed the pbw-export branch from 57a9502 to 286d40d Compare February 9, 2026 07:34

sockeye-d force-pushed the pbw-export branch from 286d40d to 986fd4f Compare February 18, 2026 08:54

sockeye-d force-pushed the pbw-export branch from d150a6d to d2475af Compare February 22, 2026 02:20

sockeye-d force-pushed the pbw-export branch from 3ebd72c to f8d2ee1 Compare February 25, 2026 09:51

sockeye-d added 7 commits February 25, 2026 23:27

Add pebble draw command export format

a01d729

PDC export working fully, it no longer rebinds the tab to the exporte…

cd0f139

…d PDC filepath, the preview is generated by parsing the PDC buffer so it should be extra accurate, more quality controls

Delete godlproject file

46a9f70

round-trip the previews so they're accurate too

e7d6e25

Add documentation to PDCImage

84d6507

Fix pebble preview dropdown menu item for new menu system, fix gdbuild

5cca1e3

pdc: fix bugs

4ab3323

pdc export: fix transformations not being applied to circles and elli…

afbac4a

…pses, add estimated file size

sockeye-d force-pushed the pbw-export branch from f8d2ee1 to afbac4a Compare February 26, 2026 07:29

MewPurPur reviewed Mar 3, 2026

View reviewed changes

	path_quality_container.visible = export_data.format in ["pdc"]
	path_quality_container.visible = (export_data.format == "pdc")

Uh oh!

Conversation

sockeye-d commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MewPurPur commented Feb 8, 2026

Uh oh!

sockeye-d commented Feb 8, 2026

Uh oh!

MewPurPur commented Feb 8, 2026

Uh oh!

sockeye-d commented Feb 9, 2026

Uh oh!

MewPurPur commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MewPurPur commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sockeye-d commented Feb 18, 2026

Uh oh!

MewPurPur commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MewPurPur commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sockeye-d commented Feb 22, 2026

Uh oh!

MewPurPur commented Feb 22, 2026

Uh oh!

MewPurPur commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MewPurPur commented Feb 25, 2026

Uh oh!

sockeye-d commented Feb 25, 2026

Uh oh!

MewPurPur commented Feb 25, 2026

Uh oh!

sockeye-d commented Feb 25, 2026

Uh oh!

MewPurPur commented Feb 25, 2026

Uh oh!

MewPurPur commented Feb 25, 2026

Uh oh!

sockeye-d commented Feb 26, 2026

Uh oh!

MewPurPur commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MewPurPur left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MewPurPur commented Mar 3, 2026

Uh oh!

MewPurPur commented Apr 23, 2026

Uh oh!

Reviewers

sockeye-d commented Jan 28, 2026 •

edited

Loading

MewPurPur commented Feb 9, 2026 •

edited

Loading

MewPurPur commented Feb 9, 2026 •

edited

Loading

MewPurPur commented Feb 19, 2026 •

edited

Loading

MewPurPur commented Feb 21, 2026 •

edited

Loading

MewPurPur commented Feb 22, 2026 •

edited

Loading

MewPurPur commented Mar 3, 2026 •

edited

Loading

MewPurPur left a comment •

edited

Loading