Skip to content

Fix exponent parsing issue #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MewPurPur merged 1 commit into from
Aug 7, 2026
Merged

Fix exponent parsing issue #1777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/data_classes/ColorParser.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
## Parser for SVG colors.
@abstract class_name ColorParser


## Adds a hash prefix to hex color strings if they don't already have one
static func add_hash_if_hex(color: String) -> String:
color = color.strip_edges()
Expand Down
18 changes: 7 additions & 11 deletions src/data_classes/NumstringParser.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ var compress_numbers: bool
var minimize_spacing: bool

## Converts a number into text for the individual fields representing path parameters.
## Those aren't represent anything directly, so they are free to be made readable and not care about formatters.
## Those don't represent anything directly, so they are free to be made readable and not care about formatters.
static func basic_num_to_text(num: float, is_angle := false) -> String:
var text := Utils.num_simple(num, Utils.MAX_ANGLE_PRECISION if is_angle else Utils.MAX_NUMERIC_PRECISION)
if text == "-0":
Expand Down Expand Up @@ -163,7 +163,7 @@ static func text_to_number_arr(text: String, current_index: int, expected_count:
parsed_numbers.append(text.substr(current_number_start_idx, current_index - current_number_start_idx).to_float())
state = NumberJumbleParseState.OUTSIDE_NUMBER_COMMA_FORBIDDEN
current_number_start_idx = -1
elif current_char == "eE":
elif current_char in "eE":
state = NumberJumbleParseState.INSIDE_NUMBER_DIRECTLY_AFTER_EXPONENT
else:
unrecognized_symbol = true
Expand Down Expand Up @@ -208,26 +208,22 @@ static func text_to_number_arr(text: String, current_index: int, expected_count:
else:
unrecognized_symbol = true
elif state == NumberJumbleParseState.INSIDE_NUMBER_INDIRECTLY_AFTER_EXPONENT:
if current_char in "01234567890":
if current_char in "1234567890":
pass
elif current_char == ".":
parsed_numbers.append(text.substr(current_number_start_idx,
current_index - current_number_start_idx).to_float())
parsed_numbers.append(text.substr(current_number_start_idx, current_index - current_number_start_idx).to_float())
state = NumberJumbleParseState.INSIDE_NUMBER_DIRECTLY_AFTER_LEADING_FLOATING_POINT
current_number_start_idx = current_index
elif current_char in " \t\n\r":
parsed_numbers.append(text.substr(current_number_start_idx,
current_index - current_number_start_idx).to_float())
parsed_numbers.append(text.substr(current_number_start_idx, current_index - current_number_start_idx).to_float())
state = NumberJumbleParseState.OUTSIDE_NUMBER_COMMA_ALLOWED
current_number_start_idx = -1
elif current_char == ",":
parsed_numbers.append(text.substr(current_number_start_idx,
current_index - current_number_start_idx).to_float())
parsed_numbers.append(text.substr(current_number_start_idx, current_index - current_number_start_idx).to_float())
state = NumberJumbleParseState.OUTSIDE_NUMBER_COMMA_FORBIDDEN
current_number_start_idx = -1
elif current_char in "-+":
parsed_numbers.append(text.substr(current_number_start_idx,
current_index - current_number_start_idx).to_float())
parsed_numbers.append(text.substr(current_number_start_idx, current_index - current_number_start_idx).to_float())
state = NumberJumbleParseState.DIRECTLY_AFTER_SIGN
current_number_start_idx = current_index
else:
Expand Down