Add undo/redo support to settings menu - #1812
Merged
MewPurPur merged 1 commit intoAug 19, 2026
Merged
Conversation
Owner
|
Awesome! I set up the architecture a few weeks ago but didn't know if I'll get to this anytime soon. I'll test and review this posthaste. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1615.
Undo and redo (Ctrl+Z / Ctrl+Y) previously only worked in the shortcuts section of the settings menu. This change routes all setting changes through the menu's
undo_redoso they can be undone/redone.Changes:
UndoRedoRefnow passesmerge_mode/backward_undo_opsthrough tocreate_action(), and exposesis_committing_action().settings_menu.gdpasses itsundo_redoto everySettingsContentGenericinstance.settings_content_generic.gdwraps the setting setter in an undo/redo action:MERGE_ENDSis used so continuous edits (e.g. dragging a color) merge into a single undo step.is_committing_action()) so widgets reflect reverted values.version_changedconnection is cleaned up ontree_exiting.Verified with Godot 4.6 stable (headless): checkbox/dropdown/numeric settings all set -> undo -> redo correctly, merged color edits undo in one step, and no stale UI state after reverting.