fix(ci): restore Docker image builds#223
Merged
Merged
Conversation
Replace the obsolete Debian GL package in the CPU image and copy README.md into metadata-only Docker build contexts so Hatchling editable installs can validate package metadata. Co-authored-by: Codex <codex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libgl1-mesa-glxpackage withlibgl1in the CPU Docker image build.README.mdinto both Docker metadata install layers so Hatchling can validatereadme = "README.md"during editable installs.Root Cause
The failing
Build CI Docker Imageworkflow was resolvingpython:3.12-slimto Debian trixie, wherelibgl1-mesa-glxhas no package candidate. The GPU Dockerfile also installed frompyproject.tomlwithout copyingREADME.md, which breaks Hatchling metadata validation.Test Coverage
All new behavior is covered by Dockerfile contract tests.
Validation
docker run --rm python:3.12-slim ... apt-cache policy ...confirmedlibgl1-mesa-glxis unavailable andlibgl1is available.uv pip install -e ".[demo,dev]".pyproject.toml,README.md, and package stub present.uv run pytest --no-cov tests/contract/test_dockerfiles.py -qpassed:2 passed.uv run ruff check .passed.uv run ruff format --check .passed.uv run mypy src/passed.MUJOCO_GL=osmesa uv run pytest -qpassed:572 passed, 3 skipped, coverage91.88%.Test Plan
python:3.12-slim.