fix(pages): preserve checkpoint nesting so deployed 3D scenes resolve#227
Merged
Conversation
The HTML report references meshcat scenes by their output-relative path (e.g. mujoco_grasp/trial_001/<cp>/meshcat_scene.html), but the Pages deploy flattened checkpoints into _site/grasp/<cp>/, so the deployed report looked for grasp/mujoco_grasp/... and every Interactive 3D Scene iframe 404'd. Deploy the grasp and g1-reach checkpoint assets under the nested path the report actually links to. https://claude.ai/code/session_01UTMNfmaXGFrNHjCYMSHWmb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the deployed site (e.g.
https://miaodx.com/roboharness/grasp/index.html), every Interactive 3D Scene panel showed a404 / File not found.Root cause
reporting.pyemits each meshcat iframesrcas a path relative to the harness output root, e.g.mujoco_grasp/trial_001/<cp>/meshcat_scene.html. This is correct for local viewing (the report sits at the output root) and is locked in by a regression test.The GitHub Pages deploy (
.github/workflows/pages.yml), however, flattened the checkpoints into_site/grasp/<cp>/. So the deployed report atgrasp/index.htmlresolved its iframe tograsp/mujoco_grasp/trial_001/<cp>/meshcat_scene.html— which didn't exist → 404. Camera images survived only because they're base64-embedded; the meshcat HTML is the one asset referenced by URL.This is FINDING-001 (
docs/designs/mujoco-grasp-report-design-audit-20260415.md) resurfacing on the deployed artifact: the earlier fix corrected the local layout but the deploy layout still diverged.Fix
Deploy the grasp and g1-reach checkpoint assets under the nested path the report actually links to (
_site/grasp/mujoco_grasp/trial_001/<cp>/and_site/g1-reach/g1_wbc_reach/trial_001/<cp>/) instead of flattening them. No source/report changes, so the existing regression test stays valid and local viewing is unaffected.Test plan
pages.ymlre-run onmaindeploys with the nested layouthttps://miaodx.com/roboharness/grasp/index.htmlloads the 3D scenes (no 404)Generated by Claude Code