Use per-platform attrdiff data from GitHub Actions - #625
Open
Zaczero wants to merge 1 commit into
Open
Conversation
Read attrdiffByPlatform from comparison artifacts and merge added/removed attrs into the imported per-system package set when that metadata is available. Classify attrs with exists = false as non-existent before broken so platform-specific removals are reported accurately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read attrdiffByPlatform from comparison artifacts and merge added/removed attrs into the imported per-system package set when that metadata is available.
Classify attrs with exists = false as non-existent before broken so platform-specific removals are reported accurately.
Fixes issues like NixOS/nixpkgs#511376, NixOS/nixpkgs#507400, where removed packages show up as "No rebuilds" which is confusing and error-prone.
Instead, it shows:
The wording could be improved so that it explicitly distinguishes removed packages from simply missing packages, but that's a secondary thing.
Depends on new attrdiffByPlatform CI artifacts introduced in NixOS/nixpkgs#509519.