-
Notifications
You must be signed in to change notification settings - Fork 199
Update README.md #841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #841
Conversation
Add parameter to do the right thing, see getsops/sops#856 (comment)
WalkthroughThe README usage example was updated to show encrypting a secret with sops instead of decrypting. The nix-shell invocation now uses "sops --encrypt secrets/example.yaml" in place of "sops secrets/example.yaml". Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md
366-366: Dollar signs used before commands without showing output
(MD014, commands-show-output)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: tests
|
|
||
| ```console | ||
| $ nix-shell -p sops --run "sops secrets/example.yaml" | ||
| $ nix-shell -p sops --run "sops --encrypt secrets/example.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--encrypt breaks the “open editor” flow; revert or update text
sops --encrypt secrets/example.yaml won’t open an editor and will write encrypted output to stdout (and error if the file doesn’t exist). This contradicts the next line “This will start your configured editor…”. Revert to the interactive edit command.
Apply:
-$ nix-shell -p sops --run "sops --encrypt secrets/example.yaml"
+$ nix-shell -p sops --run "sops secrets/example.yaml"If the intent was to encrypt an existing plaintext file instead, use sops --encrypt --in-place secrets/example.yaml and adjust the explanatory text accordingly.
Note: markdownlint MD014 also flags the $ prompt usage here; consider dropping $ or showing example output for compliance, for consistency across the doc.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| $ nix-shell -p sops --run "sops --encrypt secrets/example.yaml" | |
| $ nix-shell -p sops --run "sops secrets/example.yaml" |
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
366-366: Dollar signs used before commands without showing output
(MD014, commands-show-output)
🤖 Prompt for AI Agents
In README.md around line 366, the command shown uses `sops --encrypt
secrets/example.yaml` which breaks the interactive “open editor” flow; replace
it with the interactive edit command (e.g., `sops secrets/example.yaml`) or, if
the intent is to encrypt an existing plaintext file in-place, use `sops
--encrypt --in-place secrets/example.yaml` and update the surrounding
explanatory text to match that behavior; also remove or standardize the `$`
prompt (or show example output) to satisfy markdownlint MD014 and keep
formatting consistent across the document.
|
The |
Add parameter to do the right thing, see getsops/sops#856 (comment)
Summary by CodeRabbit