Add version check for node.js installation #7887
Closed
+24
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently implementing https://github.com/louislam/uptime-kuma (I don't know if Stephan already asked you about it, I just started doing it) which depends on node.js.
For testing I did a lot of installing and reinstalling and every time I did this node.js was pulled and installed again, despite the fact that the current version is already present. So I added just some lines to do quick check to prevent this behaviour.
New behaviour:
If the currently installed version matches the newest node.js version the installation process is skipped.