Use catf() over messagef() where appropriate#330
Merged
Conversation
MichaelChirico
force-pushed
the
push-usulxrmyurtw
branch
5 times, most recently
from
d43d355 to
bf705d4
Compare
MichaelChirico
force-pushed
the
push-usulxrmyurtw
branch
from
bf705d4 to
4781949
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
messagebeing aconditionis not quite appropriate forverbose=TRUEoutput, though there are still a few places wheremessageremains useful in the codebase.In turn this engendered a pretty big refactoring of the test suite to be a bit more in line with how I'd write this from scratch today (still a lot of work to do there...)