Skip to content

Commit cfab008

Browse files
fix: defer body close returned as was
For some reason it was causing double notifications
1 parent 6aeb587 commit cfab008

3 files changed

Lines changed: 3 additions & 11 deletions

File tree

config/samples/ddns_v1alpha1_provider.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ metadata:
44
labels:
55
app.kubernetes.io/name: go-ddns-controller
66
app.kubernetes.io/managed-by: kustomize
7-
name: provider-sample
7+
name: cloudflare-provider
88
spec:
99
name: Cloudflare
1010
secretName: cloudflare

internal/network/http.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,7 @@ import (
1010
// Will also close the ReadStream
1111
func GetBody(url string) ([]byte, error) {
1212
if resp, err := http.Get(url); err == nil {
13-
defer func() {
14-
if err := resp.Body.Close(); err != nil {
15-
fmt.Println("Error while closing response body")
16-
}
17-
}()
13+
defer resp.Body.Close()
1814

1915
if body, err := io.ReadAll(resp.Body); err == nil {
2016
return body, nil

internal/notifiers/webhook.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,7 @@ func (w *WebhookNotifier) sendToWebhook(data string) error {
6262
return err
6363
}
6464

65-
defer func() {
66-
if err := resp.Body.Close(); err != nil {
67-
slog.Error("error while closing response body", "error", err)
68-
}
69-
}()
65+
defer resp.Body.Close()
7066

7167
slog.Debug("Status Code", "code", resp.StatusCode)
7268

0 commit comments

Comments
 (0)